Merge pull request #59 from sharkdp/remove-fromChar-toString

Remove String.fromChar, Char.toString, fixes #51

Author: garyb

docs/Data/Char.md

@@ -2,14 +2,6 @@
 
 A type and functions for single characters.
 
-#### `toString`
-
-``` purescript
-toString :: Char -> String
-```
-
-Returns the string of length `1` containing only the given character.
-
 #### `toCharCode`
 
 ``` purescript

docs/Data/String.md

@@ -12,14 +12,6 @@ charAt :: Int -> String -> Maybe Char
 
 Returns the character at the given index, if the index is within bounds.
 
-#### `fromChar`
-
-``` purescript
-fromChar :: Char -> String
-```
-
-Returns a string of length `1` containing the given character.
-
 #### `singleton`
 
 ``` purescript

docs/Data/String/Regex.md

@@ -14,7 +14,7 @@ Wraps Javascript `RegExp` objects.
 
 ##### Instances
 ``` purescript
-instance showRegex :: Show Regex
+Show Regex
 ```
 
 #### `RegexFlags`

src/Data/Char.js

@@ -3,10 +3,6 @@
 
 // module Data.Char
 
-exports.toString = function (c) {
-  return c;
-};
-
 exports.toCharCode = function (c) {
   return c.charCodeAt(0);
 };

src/Data/Char.purs

@@ -1,17 +1,13 @@
 -- | A type and functions for single characters.
 module Data.Char
-  ( toString
-  , fromCharCode
+  ( fromCharCode
   , toCharCode
   , toLower
   , toUpper
   ) where
 
 import Prelude
 
--- | Returns the string of length `1` containing only the given character.
-foreign import toString :: Char -> String
-
 -- | Returns the numeric Unicode value of the character.
 foreign import toCharCode :: Char -> Int
 

src/Data/String.js

@@ -13,6 +13,10 @@ exports._charAt = function (just) {
   };
 };
 
+exports.singleton = function (c) {
+  return c;
+};
+
 exports._charCodeAt = function (just) {
   return function (nothing) {
     return function (i) {

src/Data/String.purs

@@ -5,7 +5,6 @@ module Data.String
   ( charAt
   , charCodeAt
   , fromCharArray
-  , fromChar
   , toChar
   , contains
   , indexOf
@@ -49,14 +48,9 @@ foreign import _charAt :: (forall a. a -> Maybe a)
                        -> String
                        -> Maybe Char
 
--- | Returns a string of length `1` containing the given character.
-fromChar :: Char -> String
-fromChar = C.toString
-
 -- | Returns a string of length `1` containing the given character.
 -- | Same as `fromChar`.
-singleton :: Char -> String
-singleton = fromChar
+foreign import singleton :: Char -> String
 
 -- | Returns the numeric Unicode value of the character at the given index,
 -- | if the index is within bounds.

test/Test/Data/Char.purs

@@ -6,9 +6,6 @@ import Data.Char
 import Test.Assert (assert)
 
 testChar = do
-  log "toString"
-  assert $ toString 'a' == "a"
-
   log "toCharCode"
   assert $ toCharCode 'a' == 97
   assert $ toCharCode '\n' == 10

test/Test/Data/String.purs

@@ -15,9 +15,6 @@ testString = do
   assert $ charAt 1 "ab" == Just 'b'
   assert $ charAt 2 "ab" == Nothing
 
-  log "fromChar"
-  assert $ fromChar 'a' == "a"
-
   log "singleton"
   assert $ singleton 'a' == "a"