Allow an alias name to match a command name

Author: kmvanbrunt

cmd2.py

@@ -2105,9 +2105,9 @@ def complete(self, text, state):
 
             else:
                 # Complete token against aliases and command names
-                alias_names = list(self.aliases.keys())
-                visible_commands = self.get_visible_commands()
-                strs_to_match = alias_names + visible_commands
+                alias_names = set(self.aliases.keys())
+                visible_commands = set(self.get_visible_commands())
+                strs_to_match = list(alias_names | visible_commands)
                 self.completion_matches = self.basic_complete(text, line, begidx, endidx, strs_to_match)
 
             # Handle single result
@@ -2755,12 +2755,6 @@ def do_alias(self, arglist):
             name = arglist[0]
             value = ' '.join(arglist[1:])
 
-            # Make sure the alias does not match an existing command
-            cmd_func = self._func_named(name)
-            if cmd_func is not None:
-                self.perror("Alias names cannot match an existing command: {!r}".format(name), traceback_war=False)
-                return
-
             # Check for a valid name
             for cur_char in name:
                 if cur_char not in self.identchars:

tests/test_cmd2.py

@@ -1560,11 +1560,6 @@ def test_alias(base_app, capsys):
     out = run_cmd(base_app, 'alias')
     assert out == normalize('alias fake pyscript')
 
-def test_alias_with_cmd_name(base_app, capsys):
-    run_cmd(base_app, 'alias help eos')
-    out, err = capsys.readouterr()
-    assert "cannot match an existing command" in err
-
 def test_alias_with_invalid_name(base_app, capsys):
     run_cmd(base_app, 'alias @ help')
     out, err = capsys.readouterr()