Removed required param "path" in Microservice Class (#97)

* Removed required param "path" in Microservice Class

* Updated tests and docstrings

Author: avara1986

README.md

@@ -66,7 +66,7 @@ from flask import jsonify
 
 from pyms.flask.app import Microservice
 
-ms = Microservice(path=__file__) # 1.1
+ms = Microservice() # 1.1
 app = ms.create_app() # 2.1
 
 

docs/quickstart.md

@@ -10,7 +10,7 @@ from flask import jsonify
 
 from pyms.flask.app import Microservice
 
-ms = Microservice(path=__file__) # 1.1
+ms = Microservice() # 1.1
 app = ms.create_app() # 2.1
 
 

examples/microservice_configuration/__init__.py

@@ -1,3 +1,3 @@
 from pyms.flask.app import Microservice
 
-ms = Microservice(path=__file__)
+ms = Microservice()

examples/microservice_requests/__init__.py

@@ -1,3 +1,3 @@
 from pyms.flask.app import Microservice
 
-ms = Microservice(path=__file__)
+ms = Microservice()

examples/microservice_swagger/main.py

@@ -1,6 +1,6 @@
 from pyms.flask.app import Microservice
 
-ms = Microservice(path=__file__)
+ms = Microservice()
 app = ms.create_app()
 
 if __name__ == '__main__':

pyms/flask/app/create_app.py

@@ -97,7 +97,17 @@ def example():
     _singleton = True
 
     def __init__(self, *args, **kwargs):
-        self.path = os.path.dirname(kwargs.get("path", __file__))
+        """
+        You can get the relative path from the current directory with `__file__` in path param. The path must be
+        the folder where PyMS search for default config file, default swagger definition and encrypt key.
+        :param args:
+        :param kwargs: "path", optional, the current directory where `Microservice` class is instanciated
+        """
+        path = kwargs.get("path", None)
+        self.path = os.path.abspath("")
+        if path:
+            self.path = os.path.dirname(os.path.abspath(path))
+
         validate_conf()
         self.config = get_conf(path=self.path, service=CONFIG_BASE)
         self.init_services()

tests/config-tests-flask-swagger.yml

@@ -6,7 +6,7 @@ pyms:
   config:
     DEBUG: true
     TESTING: true
-    APP_NAME: "Python Microservice With Flask"
+    APP_NAME: "Python Microservice With Flask in tests"
     APPLICATION_ROOT: /
     test_var: general
     subservice1:

tests/test_flask.py

@@ -23,7 +23,7 @@ class HomeWithFlaskTests(unittest.TestCase):
     def setUp(self):
         os.environ[CONFIGMAP_FILE_ENVIRONMENT] = os.path.join(os.path.dirname(os.path.abspath(__file__)),
                                                               "config-tests-flask.yml")
-        ms = MyMicroservice(path=__file__)
+        ms = MyMicroservice()
         ms.reload_conf()
         self.app = ms.create_app()
         self.client = self.app.test_client()
@@ -54,7 +54,7 @@ def setUp(self):
         ms = MyMicroservice(path=__file__)
         self.app = ms.create_app()
         self.client = self.app.test_client()
-        self.assertEqual("Python Microservice With Flask", self.app.config["APP_NAME"])
+        self.assertEqual("Python Microservice With Flask in tests", self.app.config["APP_NAME"])
 
     def test_healthcheck(self):
         response = self.client.get('/healthcheck')

tox.ini

@@ -4,7 +4,7 @@ envlist=py36,py37,pylint,flake8,safety,bandit,docs
 [travis]
 python =
   3.6: py36
-  3.7: py37,pylint,flake8,safety,bandit,docs
+  3.7: py37,pylint,flake8,bandit,docs
   3.8: py38
 
 [testenv]