fix: required sub-attribute creation

Author: azmeuk

scim2_tester/filling.py

@@ -13,6 +13,7 @@
 from scim2_models import ExternalReference
 from scim2_models import Mutability
 from scim2_models import Reference
+from scim2_models import Required
 from scim2_models import Resource
 from scim2_models import URIReference
 from scim2_models.utils import UNION_TYPES
@@ -208,6 +209,15 @@ def fill_complex_attribute_with_random_values(
     For SCIM reference fields, correctly sets the value field to match
     the ID extracted from the reference URL.
     """
+    if not urns:
+        urns = []
+        for field_name in type(obj).model_fields:
+            if type(obj).get_field_annotation(field_name, Required) == Required.true:
+                alias = (
+                    type(obj).model_fields[field_name].serialization_alias or field_name
+                )
+                urns.append(alias)
+
     fill_with_random_values(context, obj, urns)
     if "ref" in type(obj).model_fields and "value" in type(obj).model_fields:
         ref_type = type(obj).get_field_root_type("ref")

tests/test_filling.py

@@ -8,6 +8,7 @@
 from scim2_models import Group
 from scim2_models import Mutability
 from scim2_models import PhoneNumber
+from scim2_models import Required
 from scim2_models import User
 from scim2_models.attributes import ComplexAttribute
 from scim2_models.resources.resource import Resource
@@ -265,3 +266,23 @@ class TestResource(Resource):
     assert filled_resource.test_attr.readonly_field is None, (
         f"readonly_field should be None but got {filled_resource.test_attr.readonly_field}"
     )
+
+
+def test_resource_manager_complex_attribute_required_subfields(testing_context):
+    """Test that ResourceManager doesn't collect URNs for required sub-attributes of complex fields."""
+
+    class TestName(ComplexAttribute):
+        formatted: Annotated[str | None, Required.true] = None
+        given_name: str | None = None
+
+    class TestUser(Resource):
+        schemas: Annotated[list[str], Required.true] = ["urn:test:TestUser"]
+        name: Annotated[TestName | None, Required.true] = None
+
+    obj = TestUser()
+    urns = ["urn:test:TestUser:name"]
+    filled = fill_with_random_values(testing_context, obj, urns)
+
+    assert filled.name is not None
+    assert filled.name.formatted is not None
+    assert filled.name.given_name is None