Merge pull request #2488 from harahu/disable-ssl-tests-py37-linux

Disable failing tests for Python 3.7 on Ubuntu

Author: pquentin

trio/tests/test_ssl.py

@@ -1,6 +1,9 @@
+from __future__ import annotations
+
 import os
 import re
 import sys
+from typing import TYPE_CHECKING
 
 import pytest
 
@@ -33,6 +36,10 @@
     check_two_way_stream,
 )
 
+if TYPE_CHECKING:
+    from _pytest.mark import MarkDecorator
+
+
 # We have two different kinds of echo server fixtures we use for testing. The
 # first is a real server written using the stdlib ssl module and blocking
 # sockets. It runs in a thread and we talk to it over a real socketpair(), to
@@ -61,6 +68,12 @@
 TRIO_TEST_1_CERT.configure_cert(SERVER_CTX)
 
 
+skip_on_broken_openssl: MarkDecorator = pytest.mark.skipif(
+    sys.version_info < (3, 8) and ssl.OPENSSL_VERSION_INFO[0] > 1,
+    reason="Python 3.7 does not work with OpenSSL versions higher than 1.X",
+)
+
+
 # TLS 1.3 has a lot of changes from previous versions. So we want to run tests
 # with both TLS 1.3, and TLS 1.2.
 # "tls13" means that we're willing to negotiate TLS 1.3. Usually that's
@@ -809,6 +822,7 @@ async def test_send_all_empty_string(client_ctx):
         await s.aclose()
 
 
+@skip_on_broken_openssl
 @pytest.mark.parametrize("https_compatible", [False, True])
 async def test_SSLStream_generic(client_ctx, https_compatible):
     async def stream_maker():
@@ -1024,6 +1038,7 @@ async def test_ssl_bad_shutdown(client_ctx):
     await server.aclose()
 
 
+@skip_on_broken_openssl
 async def test_ssl_bad_shutdown_but_its_ok(client_ctx):
     client, server = ssl_memory_stream_pair(
         client_ctx,
@@ -1088,6 +1103,7 @@ def close_hook():
     assert transport_close_count == 1
 
 
+@skip_on_broken_openssl
 async def test_ssl_https_compatibility_disagreement(client_ctx):
     client, server = ssl_memory_stream_pair(
         client_ctx,
@@ -1112,6 +1128,7 @@ async def receive_and_expect_error():
         nursery.start_soon(receive_and_expect_error)
 
 
+@skip_on_broken_openssl
 async def test_https_mode_eof_before_handshake(client_ctx):
     client, server = ssl_memory_stream_pair(
         client_ctx,