post code review edits

Author: albertedwardson

Objects/codeobject.c

@@ -113,7 +113,7 @@ PyCode_ClearWatcher(int watcher_id)
 
 #define _PyCodeObject_CAST(op)  (assert(PyCode_Check(op)), (PyCodeObject *)(op))
 
-static inline int
+static int
 should_intern_string(PyObject *o)
 {
 #ifdef Py_GIL_DISABLED
@@ -196,14 +196,15 @@ intern_strings(PyObject *tuple)
     return 0;
 }
 
-#define _constants_tuple_modified(modified) if (modified) *modified = 1
 
 /* Intern constants. In the default build, this interns selected string
-   constants. In the free-threaded build, this also interns non-string
-   constants. */
+constants. In the free-threaded build, this also interns non-string
+constants. */
 static int
 intern_constants(PyObject *tuple, int *modified)
 {
+#define set_modified(modified) if (modified) *modified = 1
+
     PyInterpreterState *interp = _PyInterpreterState_GET();
     for (Py_ssize_t i = PyTuple_GET_SIZE(tuple); --i >= 0; ) {
         PyObject *v = PyTuple_GET_ITEM(tuple, i);
@@ -215,21 +216,23 @@ intern_constants(PyObject *tuple, int *modified)
             PyObject *interned = _Py_hashtable_get(INTERNED_STRINGS, v);
             if (interned == NULL) {
                 interned = PyDict_GetItemWithError(get_interned_dict(interp), v);
-                if (PyErr_Occurred()) return -1;
+                if (PyErr_Occurred()) {
+                    return -1;
+                }
             }
             if (interned != NULL && interned != v) {
                 Py_INCREF(interned);
                 PyTuple_SET_ITEM(tuple, i, interned);
                 Py_DECREF(v);
-                _constants_tuple_modified(modified);
+                set_modified(modified);
             } else
 #endif
             if (should_intern_string(v)) {
                 PyObject *w = v;
                 _PyUnicode_InternMortal(interp, &v);
                 if (w != v) {
                     PyTuple_SET_ITEM(tuple, i, v);
-                    _constants_tuple_modified(modified);
+                    set_modified(modified);
                 }
             }
         }
@@ -258,7 +261,7 @@ intern_constants(PyObject *tuple, int *modified)
 
                 PyTuple_SET_ITEM(tuple, i, v);
                 Py_DECREF(w);
-                _constants_tuple_modified(modified);
+                set_modified(modified);
             }
             Py_DECREF(tmp);
         }
@@ -287,7 +290,7 @@ intern_constants(PyObject *tuple, int *modified)
                 }
                 PyTuple_SET_ITEM(tuple, i, v);
                 Py_DECREF(slice);
-                _constants_tuple_modified(modified);
+                set_modified(modified);
             }
             Py_DECREF(tmp);
         }
@@ -311,6 +314,8 @@ intern_constants(PyObject *tuple, int *modified)
 #endif
     }
     return 0;
+
+#undef set_modified
 }
 
 /* Return a shallow copy of a tuple that is