Skip to content

Commit ac7b66b

Browse files
committed
Fix properties test and switch to .NET 10.0
1 parent 2aad885 commit ac7b66b

3 files changed

Lines changed: 9 additions & 6 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ jobs:
6161
- name: Setup .NET
6262
uses: actions/setup-dotnet@v5
6363
with:
64-
dotnet-version: '8.0.x'
64+
dotnet-version: '10.0'
6565

6666
- name: Set up Python ${{ matrix.python }}
6767
uses: astral-sh/setup-uv@v7

example/example.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22
<PropertyGroup>
3-
<TargetFrameworks>net8.0;netstandard2.0</TargetFrameworks>
3+
<TargetFrameworks>net10.0;netstandard2.0</TargetFrameworks>
44
<GenerateRuntimeConfigurationFiles>true</GenerateRuntimeConfigurationFiles>
55
</PropertyGroup>
66
<ItemGroup>

tests/test_common.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,11 @@
11
import shutil
2-
import pytest
3-
from subprocess import check_call
42
import sys
53
from pathlib import Path
4+
from subprocess import check_call
5+
6+
import pytest
7+
8+
NETCORE_VERSION = "net10.0"
69

710

811
@pytest.fixture(scope="session")
@@ -12,7 +15,7 @@ def example_netstandard(tmp_path_factory: pytest.TempPathFactory) -> Path:
1215

1316
@pytest.fixture(scope="session")
1417
def example_netcore(tmp_path_factory: pytest.TempPathFactory) -> Path:
15-
return build_example(tmp_path_factory, "net8.0")
18+
return build_example(tmp_path_factory, NETCORE_VERSION)
1619

1720

1821
def build_example(tmp_path_factory: pytest.TempPathFactory, framework: str) -> Path:
@@ -108,7 +111,7 @@ def _do_test_coreclr_command_line(example_netcore: Path):
108111
def test_coreclr_properties(example_netcore: Path):
109112
run_in_subprocess(
110113
_do_test_coreclr_autogenerated_runtimeconfig,
111-
example_netstandard,
114+
example_netcore,
112115
properties=dict(APP_CONTEXT_BASE_DIRECTORY=str(example_netcore)),
113116
)
114117

0 commit comments

Comments
 (0)