Skip to content

Commit 6db5943

Browse files
unamedkrclaude
andauthored
fix(release): drop quant-server.exe on Windows + add workflow_dispatch (#45)
The Windows build job tried to copy quant-server.exe which doesn't exist — CMakeLists.txt:311 has `if(TQ_BUILD_SERVER AND NOT MSVC)` so quant-server is intentionally not built on MSVC (uses POSIX sockets). Changes: 1. Windows build no longer passes -DTQ_BUILD_SERVER=ON (no-op anyway) and the package step no longer references quant-server.exe. 2. Added workflow_dispatch trigger so the release workflow can be re-run for an existing tag without re-tagging. 3. Each checkout step now respects github.event.inputs.tag for workflow_dispatch runs. 4. softprops/action-gh-release uses explicit tag_name from input. This unblocks the v0.12.0 GitHub Release (PyPI v0.12.0 already published successfully). Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 97a422c commit 6db5943

1 file changed

Lines changed: 18 additions & 2 deletions

File tree

.github/workflows/release.yml

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,12 @@ on:
44
push:
55
tags:
66
- "v*"
7+
workflow_dispatch:
8+
inputs:
9+
tag:
10+
description: 'Existing tag to build a release for (e.g., v0.12.0)'
11+
required: true
12+
default: 'v0.12.0'
713

814
permissions:
915
contents: write
@@ -13,6 +19,8 @@ jobs:
1319
runs-on: macos-latest
1420
steps:
1521
- uses: actions/checkout@v4
22+
with:
23+
ref: ${{ github.event.inputs.tag || github.ref }}
1624

1725
- name: Build
1826
run: |
@@ -37,6 +45,8 @@ jobs:
3745
runs-on: ubuntu-latest
3846
steps:
3947
- uses: actions/checkout@v4
48+
with:
49+
ref: ${{ github.event.inputs.tag || github.ref }}
4050

4151
- name: Build
4252
run: |
@@ -62,18 +72,23 @@ jobs:
6272
runs-on: windows-latest
6373
steps:
6474
- uses: actions/checkout@v4
75+
with:
76+
ref: ${{ github.event.inputs.tag || github.ref }}
6577

6678
- name: Build
6779
run: |
68-
cmake -B build -DCMAKE_BUILD_TYPE=Release -DTQ_BUILD_SERVER=ON
80+
# Note: TQ_BUILD_SERVER is not enabled on Windows because quant-server
81+
# uses POSIX sockets (sys/socket.h). CMakeLists.txt guards it with
82+
# `if(TQ_BUILD_SERVER AND NOT MSVC)`. Windows users should use the
83+
# Python `quantcpp serve` wrapper instead, or run the server in WSL.
84+
cmake -B build -DCMAKE_BUILD_TYPE=Release
6985
cmake --build build --config Release -j $env:NUMBER_OF_PROCESSORS
7086
7187
- name: Package
7288
shell: pwsh
7389
run: |
7490
New-Item -ItemType Directory -Force -Path quant.cpp-windows-x64
7591
Copy-Item build/Release/quant.exe quant.cpp-windows-x64/
76-
Copy-Item build/Release/quant-server.exe quant.cpp-windows-x64/
7792
if (Test-Path LICENSE) { Copy-Item LICENSE quant.cpp-windows-x64/ }
7893
if (Test-Path README.md) { Copy-Item README.md quant.cpp-windows-x64/ }
7994
Compress-Archive -Path quant.cpp-windows-x64/* -DestinationPath quant.cpp-windows-x64.zip
@@ -96,6 +111,7 @@ jobs:
96111

97112
- uses: softprops/action-gh-release@v2
98113
with:
114+
tag_name: ${{ github.event.inputs.tag || github.ref_name }}
99115
generate_release_notes: true
100116
files: |
101117
artifacts/quant.cpp-macos-arm64/quant.cpp-macos-arm64.tar.gz

0 commit comments

Comments
 (0)