Clean up and formatting

Author: rameel

src/Ramstack.FileSystem.Amazon/S3UploadStream.cs

@@ -100,14 +100,13 @@ public override void Write(ReadOnlySpan<byte> buffer)
         try
         {
             _stream.Write(buffer);
-
             if (_stream.Length >= MinPartSize)
                 UploadPart();
         }
-        catch (Exception exception)
+        catch
         {
             Abort();
-            ExceptionDispatchInfo.Throw(exception);
+            throw;
         }
     }
 
@@ -124,10 +123,10 @@ public override async ValueTask WriteAsync(ReadOnlyMemory<byte> buffer, Cancella
             if (_stream.Length >= MinPartSize)
                 await UploadPartAsync(cancellationToken).ConfigureAwait(false);
         }
-        catch (Exception exception)
+        catch
         {
             await AbortAsync(cancellationToken).ConfigureAwait(false);
-            ExceptionDispatchInfo.Throw(exception);
+            throw;
         }
     }
 
@@ -254,10 +253,10 @@ private async ValueTask UploadPartAsync(CancellationToken cancellationToken)
                 _stream.Position = 0;
                 _stream.SetLength(0);
             }
-            catch (Exception exception)
+            catch
             {
                 await AbortAsync(cancellationToken).ConfigureAwait(false);
-                ExceptionDispatchInfo.Throw(exception);
+                throw;
             }
         }
     }

src/Ramstack.FileSystem.Google/GcsWriteStream.cs

@@ -3,14 +3,14 @@
 namespace Ramstack.FileSystem.Google;
 
 /// <summary>
-/// Represents a temporary write-only stream for Google Cloud Storage operations, redirecting all write operations to a temporary file.
-/// Upon disposing or closing the stream, the data is transferred to the Azure Blob storage.
+/// Represents a temporary write-only stream that buffers data to a temporary file before uploading it to Google Cloud Storage.
+/// Data is committed to the storage bucket when the stream is disposed or closed.
 /// </summary>
 internal sealed class GcsWriteStream : Stream
 {
     private readonly GoogleFileSystem _fs;
     private readonly string _objectName;
-    private readonly FileStream _stream = CreateTempFileStream();
+    private readonly FileStream _stream;
     private bool _disposed;
 
     /// <inheritdoc />
@@ -53,6 +53,16 @@ public GcsWriteStream(GoogleFileSystem fs, string objectName)
     {
         _fs = fs;
         _objectName = objectName;
+        _stream = new FileStream(
+            Path.Combine(
+                Path.GetTempPath(),
+                Path.GetRandomFileName()),
+            FileMode.CreateNew,
+            FileAccess.ReadWrite,
+            FileShare.None,
+            bufferSize: 4096,
+            FileOptions.DeleteOnClose
+                | FileOptions.Asynchronous);
     }
 
     /// <inheritdoc />
@@ -84,7 +94,6 @@ public override void Write(ReadOnlySpan<byte> buffer)
         {
             _disposed = true;
             _stream.Close();
-
             throw;
         }
     }
@@ -104,7 +113,6 @@ public override async ValueTask WriteAsync(ReadOnlyMemory<byte> buffer, Cancella
         {
             _disposed = true;
             _stream.Close();
-
             throw;
         }
     }
@@ -176,15 +184,6 @@ await _fs.StorageClient
         }
     }
 
-    private static FileStream CreateTempFileStream()
-    {
-        const int BufferSize = 4096;
-        const FileOptions Options = FileOptions.DeleteOnClose | FileOptions.Asynchronous;
-
-        var path = Path.Combine(Path.GetTempPath(), Path.GetRandomFileName());
-        return new FileStream(path, FileMode.Create, FileAccess.ReadWrite, FileShare.Read, BufferSize, Options);
-    }
-
     [DoesNotReturn]
     private static void Error_NotSupported() =>
         throw new NotSupportedException();