Merge pull request #51 from rameel/inconsistent-tz

Fix inconsistent time's offset in PhysicalFile/PhysicalDirectory properties

Author: rameel

src/Ramstack.FileSystem.Physical/PhysicalDirectory.cs

@@ -44,9 +44,9 @@ public PhysicalDirectory(PhysicalFileSystem fileSystem, string path, string phys
 
         var properties = info.Exists
             ? VirtualNodeProperties.CreateDirectoryProperties(
-                creationTime: info.CreationTimeUtc,
+                creationTime: info.CreationTime,
                 lastAccessTime: info.LastAccessTime,
-                lastWriteTime: info.LastWriteTimeUtc)
+                lastWriteTime: info.LastWriteTime)
             : null;
 
         return new ValueTask<VirtualNodeProperties?>(properties);

src/Ramstack.FileSystem.Physical/PhysicalFile.cs

@@ -31,9 +31,9 @@ internal PhysicalFile(PhysicalFileSystem fileSystem, string path, string physica
         var file = new FileInfo(_physicalPath);
         var properties = file.Exists
             ? VirtualNodeProperties.CreateFileProperties(
-                creationTime: file.CreationTimeUtc,
+                creationTime: file.CreationTime,
                 lastAccessTime: file.LastAccessTime,
-                lastWriteTime: file.LastWriteTimeUtc,
+                lastWriteTime: file.LastWriteTime,
                 length: file.Length)
             : null;
 

tests/Ramstack.FileSystem.Physical.Tests/WriteablePhysicalFileSystemTests.cs

@@ -8,6 +8,42 @@ public class WriteablePhysicalFileSystemTests : VirtualFileSystemSpecificationTe
 {
     private readonly TempFileStorage _storage = new TempFileStorage();
 
+    [Test]
+    public async Task Directory_GetProperties_ReturnsConsistentTimezones()
+    {
+        using var fs = GetFileSystem();
+
+        var directory = await fs
+            .GetDirectory("/project")
+            .GetPropertiesAsync();
+
+        Assert.That(
+            directory.LastAccessTime.Offset,
+            Is.EqualTo(directory.LastWriteTime.Offset));
+
+        Assert.That(
+            directory.CreationTime.Offset,
+            Is.EqualTo(directory.LastWriteTime.Offset));
+    }
+
+    [Test]
+    public async Task File_GetProperties_ReturnsConsistentTimezones()
+    {
+        using var fs = GetFileSystem();
+
+        var file = await fs
+            .GetFile("/project/docs/api_reference.md")
+            .GetPropertiesAsync();
+
+        Assert.That(
+            file.LastAccessTime.Offset,
+            Is.EqualTo(file.LastWriteTime.Offset));
+
+        Assert.That(
+            file.CreationTime.Offset,
+            Is.EqualTo(file.LastWriteTime.Offset));
+    }
+
     [OneTimeTearDown]
     public void Cleanup() =>
         _storage.Dispose();