Hoist loop-invariant value.GetRawStringData

For unknown reasons, the JIT does not perform this optimization in this case, so the call is explicitly hoisted to improve performance.

Author: rameel

Ramstack.Structures/Text/StringView.cs

@@ -325,8 +325,10 @@ public StringView TrimStart(params ReadOnlySpan<char> trimChars)
         {
             for (; start < final; start++)
             {
-                for (var i = 0; i < trimChars.Length; i++)
-                    if (value.GetRawStringData(start) == trimChars[i])
+                var ch = value.GetRawStringData(start);
+
+                foreach (var trimChar in trimChars)
+                    if (ch == trimChar)
                         goto MATCHED;
 
                 break;
@@ -417,8 +419,10 @@ public StringView TrimEnd(params ReadOnlySpan<char> trimChars)
         {
             for (; final >= start; final--)
             {
-                for (var i = 0; i < trimChars.Length; i++)
-                    if (value.GetRawStringData(final) == trimChars[i])
+                var ch = value.GetRawStringData(final);
+
+                foreach (var trimChar in trimChars)
+                    if (ch == trimChar)
                         goto MATCHED;
 
                 break;
@@ -521,8 +525,10 @@ public StringView Trim(params ReadOnlySpan<char> trimChars)
         {
             for (; start <= final; start++)
             {
-                for (var i = 0; i < trimChars.Length; i++)
-                    if (value.GetRawStringData(start) == trimChars[i])
+                var ch = value.GetRawStringData(start);
+
+                foreach (var trimChar in trimChars)
+                    if (ch == trimChar)
                         goto MATCHED;
 
                 break;
@@ -531,8 +537,10 @@ public StringView Trim(params ReadOnlySpan<char> trimChars)
 
             for (; final > start; final--)
             {
-                for (var i = 0; i < trimChars.Length; i++)
-                    if (value.GetRawStringData(final) == trimChars[i])
+                var ch = value.GetRawStringData(final);
+
+                foreach (var trimChar in trimChars)
+                    if (ch == trimChar)
                         goto MATCHED;
 
                 break;