Rename dummy parameter to unused

Author: rameel

Ramstack.Structures/Collections/ArrayView`1.cs

@@ -101,17 +101,23 @@ public ArrayView(T[] array, int index, int length)
     /// Initializes a new instance of the <see cref="ArrayView{T}"/> structure that creates
     /// a view for the specified range of the elements in the specified array.
     /// </summary>
+    /// <remarks>
+    /// This constructor is intentionally minimal and skips all argument validations,
+    /// as the caller is responsible for ensuring correctness (e.g.,
+    /// <paramref name="array"/> is non-null, <paramref name="index"/> and
+    /// <paramref name="length"/> are within bounds).
+    /// </remarks>
     /// <param name="array">The array to wrap.</param>
     /// <param name="index">The zero-based index of the first element in the range.</param>
     /// <param name="length">The number of elements in the range.</param>
-    /// <param name="dummy">The dummy parameter.</param>
+    /// <param name="unused">Unused parameter, exists solely to disambiguate overloads.</param>
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    private ArrayView(T[] array, int index, int length, int dummy)
+    private ArrayView(T[] array, int index, int length, int unused)
     {
         _index = index;
         _count = length;
         _array = array;
-        _ = dummy;
+        _ = unused;
     }
 
     /// <inheritdoc cref="IEnumerable{T}.GetEnumerator"/>
@@ -132,7 +138,7 @@ public ArrayView<T> Slice(int index)
         if ((uint)index > (uint)_count)
             ThrowHelper.ThrowArgumentOutOfRangeException();
 
-        return new ArrayView<T>(_array!, _index + index, _count - index, dummy: 0);
+        return new ArrayView<T>(_array!, _index + index, _count - index, unused: 0);
     }
 
     /// <summary>
@@ -157,7 +163,7 @@ public ArrayView<T> Slice(int index, int count)
                 ThrowHelper.ThrowArgumentOutOfRangeException();
         }
 
-        return new ArrayView<T>(_array!, _index + index, count, dummy: 0);
+        return new ArrayView<T>(_array!, _index + index, count, unused: 0);
     }
 
     /// <summary>
@@ -316,7 +322,7 @@ ref array.GetRawArrayData(view._index),
     /// A <see cref="ArrayView{T}"/> representation of the array segment.
     /// </returns>
     public static implicit operator ArrayView<T>(ArraySegment<T> segment) =>
-        new(segment.Array!, segment.Offset, segment.Count, dummy: 0);
+        new(segment.Array!, segment.Offset, segment.Count, unused: 0);
 
     /// <summary>
     /// Returns a string representation of the current instance's state,

Ramstack.Structures/Text/StringView.cs

@@ -45,7 +45,7 @@ public char this[int index]
     /// </summary>
     /// <param name="value">The string to wrap.</param>
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public StringView(string value) : this(value, 0, value.Length, dummy: 0)
+    public StringView(string value) : this(value, 0, value.Length, unused: 0)
     {
     }
 
@@ -96,17 +96,23 @@ public StringView(string value, int index, int length)
     /// Initializes a new instance of the <see cref="StringView"/> structure that creates
     /// a view for the specified range of the characters in the specified string.
     /// </summary>
+    /// <remarks>
+    /// This constructor is intentionally minimal and skips all argument validations,
+    /// as the caller is responsible for ensuring correctness (e.g.,
+    /// <paramref name="value"/> is non-null, <paramref name="index"/> and
+    /// <paramref name="length"/> are within bounds).
+    /// </remarks>
     /// <param name="value">The string to wrap.</param>
     /// <param name="index">The zero-based index of the first character in the range.</param>
     /// <param name="length">The number of characters in the range.</param>
-    /// <param name="dummy">The dummy parameter.</param>
+    /// <param name="unused">Unused parameter, exists solely to disambiguate overloads.</param>
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    private StringView(string value, int index, int length, int dummy)
+    private StringView(string value, int index, int length, int unused)
     {
         _index = index;
         _length = length;
         _value = value;
-        _ = dummy;
+        _ = unused;
     }
 
     /// <inheritdoc cref="IEnumerable{T}.GetEnumerator"/>
@@ -156,7 +162,7 @@ public StringView Slice(int start)
         if ((uint)start > (uint)_length)
             ThrowHelper.ThrowArgumentOutOfRangeException();
 
-        return new StringView(_value!, _index + start, _length - start, dummy: 0);
+        return new StringView(_value!, _index + start, _length - start, unused: 0);
     }
 
     /// <summary>
@@ -182,7 +188,7 @@ public StringView Slice(int start, int length)
                 ThrowHelper.ThrowArgumentOutOfRangeException();
         }
 
-        return new StringView(_value!, _index + start, length, dummy: 0);
+        return new StringView(_value!, _index + start, length, unused: 0);
     }
 
     /// <summary>
@@ -256,7 +262,7 @@ public StringView TrimStart()
                 if (!char.IsWhiteSpace(value.GetRawStringData(start)))
                     break;
 
-        return new StringView(value!, start, final - start, dummy: 0);
+        return new StringView(value!, start, final - start, unused: 0);
     }
 
     /// <summary>
@@ -277,7 +283,7 @@ public StringView TrimStart(char trimChar)
                 if (value.GetRawStringData(start) != trimChar)
                     break;
 
-        return new StringView(value!, start, final - start, dummy: 0);
+        return new StringView(value!, start, final - start, unused: 0);
     }
 
     /// <summary>
@@ -328,7 +334,7 @@ public StringView TrimStart(ReadOnlySpan<char> trimChars)
             }
         }
 
-        return new StringView(value!, start, final - start, dummy: 0);
+        return new StringView(value!, start, final - start, unused: 0);
     }
 
     /// <summary>
@@ -348,7 +354,7 @@ public StringView TrimEnd()
                 if (!char.IsWhiteSpace(value.GetRawStringData(final)))
                     break;
 
-        return new StringView(value!, start, final + 1 - start, dummy: 0);
+        return new StringView(value!, start, final + 1 - start, unused: 0);
     }
 
     /// <summary>
@@ -369,7 +375,7 @@ public StringView TrimEnd(char trimChar)
                 if (value.GetRawStringData(final) != trimChar)
                     break;
 
-        return new StringView(value!, start, final + 1 - start, dummy: 0);
+        return new StringView(value!, start, final + 1 - start, unused: 0);
     }
 
     /// <summary>
@@ -420,7 +426,7 @@ public StringView TrimEnd(ReadOnlySpan<char> trimChars)
             }
         }
 
-        return new StringView(value!, start, final + 1 - start, dummy: 0);
+        return new StringView(value!, start, final + 1 - start, unused: 0);
     }
 
     /// <summary>
@@ -446,7 +452,7 @@ public StringView Trim()
                     break;
         }
 
-        return new StringView(value!, start, final + 1 - start, dummy: 0);
+        return new StringView(value!, start, final + 1 - start, unused: 0);
     }
 
     /// <summary>
@@ -473,7 +479,7 @@ public StringView Trim(char trimChar)
                     break;
         }
 
-        return new StringView(value!, start, final + 1 - start, dummy: 0);
+        return new StringView(value!, start, final + 1 - start, unused: 0);
     }
 
     /// <summary>
@@ -534,7 +540,7 @@ public StringView Trim(ReadOnlySpan<char> trimChars)
             }
         }
 
-        return new StringView(value!, start, final + 1 - start, dummy: 0);
+        return new StringView(value!, start, final + 1 - start, unused: 0);
     }
 
     /// <summary>