JBDS-4490 On macOS Fuse Runtime installers let to continue w/o java detected

Author: dgolovin

browser/model/installable-item.js

@@ -17,6 +17,7 @@ class InstallableItem {
     this.productName = requirement.name;
     this.productVersion = requirement.version;
     this.productDesc = requirement.description;
+    this.isInstallable = requirement.installable;
     this.targetFolderName = targetFolderName;
     this.installerDataSvc = installerDataSvc;
     this.existingInstall = false;

browser/model/jbossfuse.js

@@ -125,6 +125,13 @@ class FusePlatformInstall extends InstallableItem {
   get javaPath() {
     return path.join(this.installerDataSvc.jdkDir(), 'bin', 'java');
   }
+
+  isConfigurationValid() {
+    let jdk = this.installerDataSvc.getInstallable('jdk');
+    return jdk.isConfigured()
+      && this.isConfigured()
+      || this.isSkipped();
+  }
 }
 
 function installGenerator(jbosseapInstallDir) {

browser/model/jbossfusekaraf.js

@@ -70,6 +70,13 @@ class FusePlatformInstallKaraf extends InstallableItem {
       return Promise.reject(error);
     });
   }
+
+  isConfigurationValid() {
+    let jdk = this.installerDataSvc.getInstallable('jdk');
+    return jdk.isConfigured()
+      && this.isConfigured()
+      || this.isSkipped();
+  }
 }
 
 function fromJson({installerDataSvc, targetFolderName, downloadUrl, fileName, sha256sum}) {

browser/model/jdk-install.js

@@ -203,22 +203,6 @@ class JdkInstall extends InstallableItem {
     return super.isConfigured();
   }
 
-  isDetected() {
-    if (Platform.getOS() === 'darwin') {
-      return true;
-    } else {
-      return super.isDetected();
-    }
-  }
-
-  isNotDetected() {
-    if (Platform.getOS() === 'darwin') {
-      return false;
-    } else {
-      return super.isNotDetected();
-    }
-  }
-
   isDisabled() {
     return !this.hasOption('detected') && (this.references > 0)
     || this.hasOption('detected') && !this.option.detected.valid

browser/pages/confirm/controller.js

@@ -83,7 +83,7 @@ class ConfirmController {
         if(installer.isSelected()) {
           for(let dep of graph.dependenciesOf(node)) {
             let depInstaller = checkboxModel[dep];
-            if(depInstaller.references === 0 && depInstaller.isNotDetected()) {
+            if(depInstaller.isInstallable && depInstaller.references === 0 && depInstaller.isNotDetected()) {
               depInstaller.selectedOption = 'install';
             }
             depInstaller.references++;

requirements.json

@@ -131,6 +131,7 @@
         "sha256sum": "",
         "version": "1.8.0",
         "virusTotalReport": "",
+        "defaultOption": "detected",
         "messages": {
           "dependency": {
             "message": "Due to licence limitations we may not install Java for you. Please install JDK version 1.8.0 downloaded from this location and restart the Installer to continue.",