Skip to content

Commit d95157c

Browse files
dgolovinjrichter1
authored andcommitted
Select Open JDK 8 to install if required and Java 9 detected
1 parent f315f4e commit d95157c

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

browser/model/jdk-install.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ class JdkInstall extends InstallableItem {
8484
}
8585

8686
getMsiSearchScriptData() {
87-
return 'REG QUERY HKLM\\Software\\Microsoft\\Windows\\CurrentVersion\\Uninstall /f "OpenJDK" /s';
87+
return 'REG QUERY HKLM\\Software\\Microsoft\\Windows\\CurrentVersion\\Uninstall /f "OpenJDK 1.8.0" /s';
8888
}
8989

9090
findMsiInstalledJava() {
@@ -176,7 +176,7 @@ class JdkInstall extends InstallableItem {
176176

177177
isDisabled() {
178178
return !this.hasOption('detected') && (this.references > 0)
179-
|| this.hasOption('detected') && !this.option.detected.valid
179+
|| this.hasOption('detected') && !this.option.detected.valid && (this.references > 0)
180180
|| this.hasOption('detected') && this.option.detected.valid && this.openJdkMsi
181181
|| Platform.OS === 'darwin';
182182
}

browser/pages/selection/controller.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,10 @@ class SelectionController {
129129
if(installer.isSelected()) {
130130
for(let dep of graph.dependenciesOf(node)) {
131131
let depInstaller = checkboxModel[dep];
132-
if(depInstaller.isInstallable && depInstaller.references === 0 && depInstaller.isNotDetected()) {
132+
if(depInstaller.isInstallable
133+
&& !depInstaller.isDisabled()
134+
&& depInstaller.references === 0
135+
&& (depInstaller.isNotDetected() || depInstaller.isInvalidVersionDetected())) {
133136
depInstaller.selectedOption = 'install';
134137
}
135138
depInstaller.references++;

0 commit comments

Comments
 (0)