Add missing ids and adjust tests

Author: jrichter1

browser/directives/componentPanel.html

@@ -14,18 +14,18 @@
             <div id="{{item.keyName}}-newer-warning" ng-show="item.option.detected.warning !== '' && item.selectedOption === 'detected'" class="has-warning">
               <div class="help-block">
                 <span class="pficon pficon-warning-triangle-o"></span>
-                <span>Newer than required!</span>
+                <span id="{{item.keyName}}-newer-message">Newer than required!</span>
               </div>
             </div>
             <div id="{{item.keyName}}-older-warning" ng-show="item.option.detected.error !=='' && item.selectedOption === 'detected'" class="has-warning">
               <div class="help-block">
               <span class="pficon pficon-warning-triangle-o"></span>
-                <span>Older than required!</span>
+                <span id="{{item.keyName}}-older-message">Older than required!</span>
               </div>
             </div>
           </div>
         </div>
-        <span id="{{item.keyName}}-name" class="product-name">{{item.productName}}</span><span id="{{item.keyName}-version" class="product-version">{{item.version}}</span>
+        <span id="{{item.keyName}}-name" class="product-name">{{item.productName}}</span><span id="{{item.keyName}}-version" class="product-version">{{item.version}}</span>
         <div id="{{item.keyName}}-description">{{item.productDesc}}</div>
       </div>
     </div>

browser/main.js

@@ -35,7 +35,7 @@ let mainModule =
     .directive(breadcrumb.name, breadcrumb)
     .directive(pathValidator.name, pathValidator)
     .config( ['$stateProvider', '$urlRouterProvider', ($stateProvider, $urlRouterProvider) => {
-      $urlRouterProvider.otherwise('/confirm');
+      $urlRouterProvider.otherwise('/account');
       $stateProvider
         .state('account', {
           url: '/account',

test/ui/confirm-test.js

@@ -18,8 +18,8 @@ delete requirements.hyperv;
 
 const messages = {
   detected: 'Using detected version',
-  older: 'Older than recommended!',
-  newer: 'Newer than recommended!'
+  older: 'Older than required!',
+  newer: 'Newer than required!'
 };
 
 describe('Confirm page', function() {
@@ -63,7 +63,7 @@ describe('Confirm page', function() {
             requirements[key].installedNote = element(By.id(key + '-installed-note'));
             requirements[key].newerWarning = element(By.id(key + '-newer-warning'));
             requirements[key].newerMessage = element(By.id(key + '-newer-message'));
-            requirements[key].olderError = element(By.id(key + '-older-error'));
+            requirements[key].olderWarning = element(By.id(key + '-older-warning'));
             requirements[key].olderMessage = element(By.id(key + '-older-message'));
           }
         }
@@ -76,7 +76,7 @@ describe('Confirm page', function() {
 
     //scoll down and select Java if it is deselected by default so that all panels appear on install screen
     afterAll(function() {
-      let checkbox = requirements.jdk.panel.all(By.model('checkboxModel.jdk.selectedOption')).first();
+      let checkbox = requirements.jdk.panel.all(By.model('item.selectedOption')).first();
       browser.executeScript('window.scrollTo(0,10000);').then(function() {
         return checkbox.isEnabled().then(function(enabled) {
           if (enabled) {
@@ -151,9 +151,9 @@ function testComponentPanel(key) {
         expect(component.newerMessage.getAttribute('innerHTML')).toEqual(messages.newer);
       });
 
-      it('older versions should come with an error', function() {
-        expect(component.olderError.isPresent()).toBe(true);
-        expect(component.olderError.getAttribute('class')).toMatch('has-error');
+      it('older versions should come with a warning', function() {
+        expect(component.olderWarning.isPresent()).toBe(true);
+        expect(component.olderWarning.getAttribute('class')).toMatch('has-warning');
         expect(component.olderMessage.getAttribute('innerHTML')).toEqual(messages.older);
       });
     }