Support spaces on mac, fixes #999

Author: jrichter1

browser/services/platform.js

@@ -209,7 +209,7 @@ class Platform {
         return Promise.resolve();
       },
       default: ()=> {
-        return pify(child_process.exec)(`chmod +x ${file}`);
+        return pify(child_process.exec)(`chmod +x '${file}'`);
       }
     });
   }
@@ -255,7 +255,7 @@ class Platform {
     let commands = [];
     executables.forEach(function(executable) {
       let name = path.parse(executable).name;
-      commands.push(`rm -f /usr/local/bin/${name}; ln -s ${executable} /usr/local/bin/${name};`);
+      commands.push(`rm -f /usr/local/bin/${name}; ln -s '${executable}' /usr/local/bin/${name};`);
     });
     let osaScript = [
       'osascript',

test/unit/model/cdk-test.js

@@ -367,8 +367,8 @@ describe('CDK installer', function() {
         return new Promise((resolve, reject)=>{
           installer.installAfterRequirements(fakeProgress, resolve, reject);
         }).then(()=>{
-          expect(child_process.exec).calledWith('chmod +x ' + path.join('ocBinRoot', 'minishift'));
-          expect(child_process.exec).calledWith('chmod +x ' + path.join(process.cwd(), 'Users', 'dev1', '.minishift', 'cache', 'oc', '1.4.1', 'oc'));
+          expect(child_process.exec).calledWith('chmod +x \'' + path.join('ocBinRoot', 'minishift') + '\'');
+          expect(child_process.exec).calledWith('chmod +x \'' + path.join(process.cwd(), 'Users', 'dev1', '.minishift', 'cache', 'oc', '1.4.1', 'oc') + '\'');
         });
       });