Skip to content

Commit f7b4daa

Browse files
committed
Fix conditional dependency tesolution
1 parent 44f4f54 commit f7b4daa

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

browser/services/componentLoader.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,10 @@ class ComponentLoader {
113113
let orDeps = dep.split('||');
114114
for(let orDep of orDeps) {
115115
let installable = svc.getInstallable(orDep);
116-
if(installable.isDetected()) {
116+
let req = svc.getRequirementByName(orDep);
117+
// temp solution for conditional dependency resolution
118+
// would work for hyperv || virtualbox but not in general
119+
if(installable.isValidVersionDetected() || req.installable === true) {
117120
graph.addDependency(key, orDep);
118121
break;
119122
}

0 commit comments

Comments
 (0)