Skip to content

Commit 37e06a4

Browse files
keithchongkeithchong
committed
Update based on Atif's comments (#8558, #9202)
Signed-off-by: Keith Chong <kykchong@redhat.com>
1 parent 1018bbb commit 37e06a4

6 files changed

Lines changed: 24 additions & 35 deletions

File tree

‎locales/en/plugin__gitops-plugin.json‎

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -146,8 +146,8 @@
146146
"Argo CD project that this ApplicationSet belongs to.": "Argo CD project that this ApplicationSet belongs to.",
147147
"Git repository URL where the ApplicationSet configuration is stored.": "Git repository URL where the ApplicationSet configuration is stored.",
148148
"Applications": "ArgoCD Applications",
149-
"Edit Application Set": "Edit Application Set",
150-
"Delete Application Set": "Delete Application Set",
149+
"Edit ApplicationSet": "Edit ApplicationSet",
150+
"Delete ApplicationSet": "Delete ApplicationSet",
151151
"AppSet ownerReference Tree View": "AppSet ownerReference Tree View",
152152
"Progressive Sync Flow View": "Progressive Sync Flow View",
153153
"Expand or collapse all progressive sync step groups": "Expand or collapse all progressive sync step groups",
@@ -315,8 +315,8 @@
315315
"There are no Argo CD Applications in this project.": "There are no Argo CD Applications in this project.",
316316
"There are no Argo CD Applications in all projects.": "There are no Argo CD Applications in all projects.",
317317
"There was an error retrieving applications. Check your connection and reload the page.": "There was an error retrieving applications. Check your connection and reload the page.",
318-
"Application Set Applications": "Application Set Applications",
319-
"The graph and table views show the Application Set's applications. Use the filter below the graph to filter applications based on their health and sync status.": "The graph and table views show the Application Set's applications. Use the filter below the graph to filter applications based on their health and sync status.",
318+
"ApplicationSet Applications": "ApplicationSet Applications",
319+
"The graph and table views show the ApplicationSet's applications. Use the filter below the graph to filter applications based on their health and sync status.": "The graph and table views show the ApplicationSet's applications. Use the filter below the graph to filter applications based on their health and sync status.",
320320
"No Argo CD ApplicationSets match the label filter": "No Argo CD ApplicationSets match the label filter",
321321
"Try removing the filter or selecting a different label to see more ApplicationSets.": "Try removing the filter or selecting a different label to see more ApplicationSets.",
322322
"There are no Argo CD ApplicationSets in this project.": "There are no Argo CD ApplicationSets in this project.",
@@ -339,8 +339,6 @@
339339
"Stop": "Stop",
340340
"Refresh": "Refresh",
341341
"Refresh (Hard)": "Refresh (Hard)",
342-
"Edit ApplicationSet": "Edit ApplicationSet",
343-
"Delete ApplicationSet": "Delete ApplicationSet",
344342
"Actions": "Actions",
345343
"You don't have permission to perform this action": "You don't have permission to perform this action",
346344
"annotations": "annotations",

‎locales/ja/plugin__gitops-plugin.json‎

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -146,8 +146,8 @@
146146
"Argo CD project that this ApplicationSet belongs to.": "Argo CD project that this ApplicationSet belongs to.",
147147
"Git repository URL where the ApplicationSet configuration is stored.": "Git repository URL where the ApplicationSet configuration is stored.",
148148
"Applications": "Applications",
149-
"Edit Application Set": "Edit Application Set",
150-
"Delete Application Set": "Delete Application Set",
149+
"Edit ApplicationSet": "Edit ApplicationSet",
150+
"Delete ApplicationSet": "Delete ApplicationSet",
151151
"AppSet ownerReference Tree View": "AppSet ownerReference Tree View",
152152
"Progressive Sync Flow View": "Progressive Sync Flow View",
153153
"Expand or collapse all progressive sync step groups": "Expand or collapse all progressive sync step groups",
@@ -315,8 +315,8 @@
315315
"There are no Argo CD Applications in this project.": "There are no Argo CD Applications in this project.",
316316
"There are no Argo CD Applications in all projects.": "There are no Argo CD Applications in all projects.",
317317
"There was an error retrieving applications. Check your connection and reload the page.": "There was an error retrieving applications. Check your connection and reload the page.",
318-
"Application Set Applications": "Application Set Applications",
319-
"The graph and table views show the Application Set's applications. Use the filter below the graph to filter applications based on their health and sync status.": "The graph and table views show the Application Set's applications. Use the filter below the graph to filter applications based on their health and sync status.",
318+
"ApplicationSet Applications": "ApplicationSet Applications",
319+
"The graph and table views show the ApplicationSet's applications. Use the filter below the graph to filter applications based on their health and sync status.": "The graph and table views show the ApplicationSet's applications. Use the filter below the graph to filter applications based on their health and sync status.",
320320
"No Argo CD ApplicationSets match the label filter": "No Argo CD ApplicationSets match the label filter",
321321
"Try removing the filter or selecting a different label to see more ApplicationSets.": "Try removing the filter or selecting a different label to see more ApplicationSets.",
322322
"There are no Argo CD ApplicationSets in this project.": "There are no Argo CD ApplicationSets in this project.",
@@ -339,8 +339,6 @@
339339
"Stop": "Stop",
340340
"Refresh": "Refresh",
341341
"Refresh (Hard)": "Refresh (Hard)",
342-
"Edit ApplicationSet": "Edit ApplicationSet",
343-
"Delete ApplicationSet": "Delete ApplicationSet",
344342
"Actions": "Actions",
345343
"You don't have permission to perform this action": "You don't have permission to perform this action",
346344
"annotations": "annotations",

‎locales/ko/plugin__gitops-plugin.json‎

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -146,8 +146,8 @@
146146
"Argo CD project that this ApplicationSet belongs to.": "Argo CD project that this ApplicationSet belongs to.",
147147
"Git repository URL where the ApplicationSet configuration is stored.": "Git repository URL where the ApplicationSet configuration is stored.",
148148
"Applications": "Applications",
149-
"Edit Application Set": "Edit Application Set",
150-
"Delete Application Set": "Delete Application Set",
149+
"Edit ApplicationSet": "Edit ApplicationSet",
150+
"Delete ApplicationSet": "Delete ApplicationSet",
151151
"AppSet ownerReference Tree View": "AppSet ownerReference Tree View",
152152
"Progressive Sync Flow View": "Progressive Sync Flow View",
153153
"Expand or collapse all progressive sync step groups": "Expand or collapse all progressive sync step groups",
@@ -315,8 +315,8 @@
315315
"There are no Argo CD Applications in this project.": "There are no Argo CD Applications in this project.",
316316
"There are no Argo CD Applications in all projects.": "There are no Argo CD Applications in all projects.",
317317
"There was an error retrieving applications. Check your connection and reload the page.": "There was an error retrieving applications. Check your connection and reload the page.",
318-
"Application Set Applications": "Application Set Applications",
319-
"The graph and table views show the Application Set's applications. Use the filter below the graph to filter applications based on their health and sync status.": "The graph and table views show the Application Set's applications. Use the filter below the graph to filter applications based on their health and sync status.",
318+
"ApplicationSet Applications": "ApplicationSet Applications",
319+
"The graph and table views show the ApplicationSet's applications. Use the filter below the graph to filter applications based on their health and sync status.": "The graph and table views show the ApplicationSet's applications. Use the filter below the graph to filter applications based on their health and sync status.",
320320
"No Argo CD ApplicationSets match the label filter": "No Argo CD ApplicationSets match the label filter",
321321
"Try removing the filter or selecting a different label to see more ApplicationSets.": "Try removing the filter or selecting a different label to see more ApplicationSets.",
322322
"There are no Argo CD ApplicationSets in this project.": "There are no Argo CD ApplicationSets in this project.",
@@ -339,8 +339,6 @@
339339
"Stop": "Stop",
340340
"Refresh": "Refresh",
341341
"Refresh (Hard)": "Refresh (Hard)",
342-
"Edit ApplicationSet": "Edit ApplicationSet",
343-
"Delete ApplicationSet": "Delete ApplicationSet",
344342
"Actions": "Actions",
345343
"You don't have permission to perform this action": "You don't have permission to perform this action",
346344
"annotations": "annotations",

‎locales/zh/plugin__gitops-plugin.json‎

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -146,8 +146,8 @@
146146
"Argo CD project that this ApplicationSet belongs to.": "Argo CD project that this ApplicationSet belongs to.",
147147
"Git repository URL where the ApplicationSet configuration is stored.": "Git repository URL where the ApplicationSet configuration is stored.",
148148
"Applications": "Applications",
149-
"Edit Application Set": "Edit Application Set",
150-
"Delete Application Set": "Delete Application Set",
149+
"Edit ApplicationSet": "Edit ApplicationSet",
150+
"Delete ApplicationSet": "Delete ApplicationSet",
151151
"AppSet ownerReference Tree View": "AppSet ownerReference Tree View",
152152
"Progressive Sync Flow View": "Progressive Sync Flow View",
153153
"Expand or collapse all progressive sync step groups": "Expand or collapse all progressive sync step groups",
@@ -315,8 +315,8 @@
315315
"There are no Argo CD Applications in this project.": "There are no Argo CD Applications in this project.",
316316
"There are no Argo CD Applications in all projects.": "There are no Argo CD Applications in all projects.",
317317
"There was an error retrieving applications. Check your connection and reload the page.": "There was an error retrieving applications. Check your connection and reload the page.",
318-
"Application Set Applications": "Application Set Applications",
319-
"The graph and table views show the Application Set's applications. Use the filter below the graph to filter applications based on their health and sync status.": "The graph and table views show the Application Set's applications. Use the filter below the graph to filter applications based on their health and sync status.",
318+
"ApplicationSet Applications": "ApplicationSet Applications",
319+
"The graph and table views show the ApplicationSet's applications. Use the filter below the graph to filter applications based on their health and sync status.": "The graph and table views show the ApplicationSet's applications. Use the filter below the graph to filter applications based on their health and sync status.",
320320
"No Argo CD ApplicationSets match the label filter": "No Argo CD ApplicationSets match the label filter",
321321
"Try removing the filter or selecting a different label to see more ApplicationSets.": "Try removing the filter or selecting a different label to see more ApplicationSets.",
322322
"There are no Argo CD ApplicationSets in this project.": "There are no Argo CD ApplicationSets in this project.",
@@ -339,8 +339,6 @@
339339
"Stop": "Stop",
340340
"Refresh": "Refresh",
341341
"Refresh (Hard)": "Refresh (Hard)",
342-
"Edit ApplicationSet": "Edit ApplicationSet",
343-
"Delete ApplicationSet": "Delete ApplicationSet",
344342
"Actions": "Actions",
345343
"You don't have permission to perform this action": "You don't have permission to perform this action",
346344
"annotations": "annotations",

‎src/gitops/components/appset/graph/ApplicationSetGraphView.tsx‎

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -204,13 +204,13 @@ const AppSetContextMenuItem: React.FC<AppSetContextMenuItemProps> = ({
204204
`/k8s/ns/${applicationSet.metadata?.namespace}/${applicationModelRef}/${applicationSet.metadata?.name}/yaml`,
205205
);
206206
break;
207-
case t('Edit Application Set'):
207+
case t('Edit ApplicationSet'):
208208
navigate(
209209
`/k8s/ns/${applicationSet.metadata?.namespace}/${applicationSetModelRef}/${applicationSet.metadata?.name}/yaml`,
210210
);
211211
break;
212212
case t('Delete Application'):
213-
case t('Delete Application Set'):
213+
case t('Delete ApplicationSet'):
214214
launchDeleteModal();
215215
break;
216216
}
@@ -299,8 +299,8 @@ const createAppSetComponentFactory =
299299
paramsRef,
300300
t('Edit labels'),
301301
t('Edit annotations'),
302-
t('Edit Application Set'),
303-
t('Delete Application Set'),
302+
t('Edit ApplicationSet'),
303+
t('Delete ApplicationSet'),
304304
),
305305
)(withSelection()(ApplicationSetNode));
306306
default:
@@ -334,8 +334,8 @@ export const ApplicationSetGraphView: React.FC<{
334334
const [treeViewLayout, setTreeViewLayout] = useUserSettings(
335335
'redhat.gitops.appSetTreeViewLayout',
336336
isProgressiveSyncEnabled
337-
? TreeViewLayout.OWNER_REFERENCE_LAYOUT
338-
: TreeViewLayout.PROGRESSIVE_SYNC_FLOW_LAYOUT,
337+
? TreeViewLayout.PROGRESSIVE_SYNC_FLOW_LAYOUT
338+
: TreeViewLayout.OWNER_REFERENCE_LAYOUT,
339339
false,
340340
);
341341
// Track expanded step-groups - only expanded step-groups have their app nodes included in initialNodes
@@ -759,9 +759,6 @@ export const ApplicationSetGraphView: React.FC<{
759759
// Re-layout with collapsed sizes
760760
graph.layout();
761761
});
762-
} else if (!initialCollapseAppliedRef.current && treeViewLayout) {
763-
// When treeViewLayout is OWNER_REFERENCE_LAYOUT, mark initial collapse as done without collapsing
764-
initialCollapseAppliedRef.current = true;
765762
}
766763
}, [
767764
controller,

‎src/gitops/components/shared/ApplicationList.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -226,12 +226,12 @@ const ApplicationList: React.FC<ApplicationProps> = ({
226226
<Flex flex={{ default: 'flexDefault' }}>
227227
{/* {showTitle == undefined && ( */}
228228
<Title headingLevel="h2" className="co-section-heading">
229-
{t('Application Set Applications')}
229+
{t('ApplicationSet Applications')}
230230
</Title>
231231
{/* )} */}
232232
<FlexItem fullWidth={{ default: 'fullWidth' }}>
233233
{t(
234-
"The graph and table views show the Application Set's applications. Use the filter below the graph to filter applications based on their health and sync status.",
234+
"The graph and table views show the ApplicationSet's applications. Use the filter below the graph to filter applications based on their health and sync status.",
235235
)}
236236
</FlexItem>
237237
<FlexItem

0 commit comments

Comments
 (0)