destructure record rest elements - fixes #8311

Author: tsnobip

analysis/reanalyze/src/DeadValue.ml

@@ -228,7 +228,7 @@ let collectPattern ~config ~refs :
  fun super self pat ->
   let posFrom = pat.Typedtree.pat_loc.loc_start in
   (match pat.pat_desc with
-  | Typedtree.Tpat_record (cases, _clodsedFlag) ->
+  | Typedtree.Tpat_record (cases, _clodsedFlag, _rest) ->
     cases
     |> List.iter (fun (_loc, {Types.lbl_loc = {loc_start = posTo}}, _pat, _) ->
            if !Config.analyzeTypes then

analysis/src/CompletionFrontEnd.ml

@@ -514,7 +514,7 @@ let completionWithParser1 ~currentFile ~debug ~offset ~path ~posCursor
           (NPolyvariantPayload {itemNum = 0; constructorName = txt}
           :: patternPath)
         ?contextPath p
-    | Ppat_record (fields, _) ->
+    | Ppat_record (fields, _, _rest) ->
       Ext_list.iter fields (fun {lid = fname; x = p} ->
           match fname with
           | {Location.txt = Longident.Lident fname} ->

analysis/src/CompletionPatterns.ml

@@ -102,12 +102,12 @@ and traversePattern (pat : Parsetree.pattern) ~patternPath ~locHasCursor
            [Completable.NTupleItem {itemNum}] @ patternPath)
          ~resultFromFoundItemNum:(fun itemNum ->
            [Completable.NTupleItem {itemNum = itemNum + 1}] @ patternPath)
-  | Ppat_record ([], _) ->
+  | Ppat_record ([], _, _rest) ->
     (* Empty fields means we're in a record body `{}`. Complete for the fields. *)
     someIfHasCursor
       ("", [Completable.NRecordBody {seenFields = []}] @ patternPath)
       "Ppat_record(empty)"
-  | Ppat_record (fields, _) -> (
+  | Ppat_record (fields, _, _rest) -> (
     let fieldWithCursor = ref None in
     let fieldWithPatHole = ref None in
     Ext_list.iter fields (fun {lid = fname; x = f} ->

analysis/src/DumpAst.ml

@@ -99,7 +99,7 @@ let rec printPattern pattern ~pos ~indentation =
       | None -> ""
       | Some pat -> "," ^ printPattern pat ~pos ~indentation)
     ^ ")"
-  | Ppat_record (fields, _) ->
+  | Ppat_record (fields, _, _rest) ->
     "Ppat_record(\n"
     ^ addIndentation (indentation + 1)
     ^ "fields:\n"

analysis/src/Hint.ml

@@ -43,7 +43,7 @@ let inlay ~path ~pos ~maxLength ~debug =
   let rec processPattern (pat : Parsetree.pattern) =
     match pat.ppat_desc with
     | Ppat_tuple pl -> pl |> List.iter processPattern
-    | Ppat_record (fields, _) ->
+    | Ppat_record (fields, _, _rest) ->
       Ext_list.iter fields (fun {x = p} -> processPattern p)
     | Ppat_array fields -> fields |> List.iter processPattern
     | Ppat_var {loc} -> push loc Type

analysis/src/ProcessCmt.ml

@@ -512,7 +512,7 @@ let rec forStructureItem ~(env : SharedTypes.Env.t) ~(exported : Exported.t)
       | Tpat_tuple pats | Tpat_array pats | Tpat_construct (_, _, pats) ->
         pats |> List.iter (fun p -> handlePattern [] p)
       | Tpat_or (p, _, _) -> handlePattern [] p
-      | Tpat_record (items, _) ->
+      | Tpat_record (items, _, _rest) ->
         items |> List.iter (fun (_, _, p, _) -> handlePattern [] p)
       | Tpat_variant (_, Some p, _) -> handlePattern [] p
       | Tpat_variant (_, None, _) | Tpat_any | Tpat_constant _ -> ()

analysis/src/ProcessExtra.ml

@@ -391,7 +391,7 @@ let pat ~(file : File.t) ~env ~extra (iter : Tast_iterator.iterator)
   in
   (* Log.log("Entering pattern " ++ Utils.showLocation(pat_loc)); *)
   (match pattern.pat_desc with
-  | Tpat_record (items, _) ->
+  | Tpat_record (items, _, _rest) ->
     addForRecord ~env ~extra ~recordType:pattern.pat_type items
   | Tpat_construct (lident, constructor, _) ->
     addForConstructor ~env ~extra pattern.pat_type lident constructor

analysis/src/SemanticTokens.ml

@@ -231,7 +231,7 @@ let command ~debug ~emitter ~path =
     | Ppat_construct ({txt = Lident ("true" | "false")}, _) ->
       (* Don't emit true or false *)
       Ast_iterator.default_iterator.pat iterator p
-    | Ppat_record (cases, _) ->
+    | Ppat_record (cases, _, _rest) ->
       Ext_list.iter cases (fun {lid = label} ->
           emitter |> emitRecordLabel ~label ~debug);
       Ast_iterator.default_iterator.pat iterator p

analysis/src/SignatureHelp.ml

@@ -664,7 +664,8 @@ let signatureHelp ~path ~pos ~currentFile ~debug ~allowForConstructorPayloads =
                 match tupleItemWithCursor with
                 | None -> -1
                 | Some i -> i)
-              | `ConstructorPat (_, {ppat_desc = Ppat_record (fields, _)}) -> (
+              | `ConstructorPat (_, {ppat_desc = Ppat_record (fields, _, _rest)})
+                -> (
                 let fieldNameWithCursor =
                   fields
                   |> List.find_map

analysis/src/Xform.ml

@@ -76,7 +76,7 @@ module IfThenElse = struct
       in
       match listToPat ~itemToPat items with
       | None -> None
-      | Some patItems -> Some (mkPat (Ppat_record (patItems, Closed))))
+      | Some patItems -> Some (mkPat (Ppat_record (patItems, Closed, None))))
     | Pexp_record (_, Some _) -> None
     | _ -> None