.resi tests

Author: cknitt

compiler/ml/typemod.ml

@@ -870,6 +870,9 @@ and transl_signature env sg =
         let trem, rem, final_env = transl_sig newenv srem in
         (mksig (Tsig_include incl) env loc :: trem, sg @ rem, final_env)
       | Psig_attribute x ->
+        (* The frontend pre-pass already emitted @@ppwarning and malformed
+           @@warning diagnostics; only thread the warning state here so the
+           remaining signature items see the right settings. *)
         Builtin_attributes.warning_scope ~ppwarning:false
           ~report_attribute_errors:false [x] (fun () ->
             let trem, rem, final_env = transl_sig env srem in
@@ -1605,6 +1608,8 @@ and type_structure ?(toplevel = false) funct_body anchor env sstr scope =
       Cmt_format.set_saved_types
         (Cmt_format.Partial_structure_item str :: previous_saved_types);
       let str_rem, sig_rem, final_env =
+        (* Floating warning-attribute diagnostics are handled in the frontend
+           pass; this scope only applies their effect to following items. *)
         Builtin_attributes.warning_scope ~ppwarning:false
           ~report_attribute_errors:false [x] (fun () -> type_struct env srem)
       in

tests/build_tests/super_errors/expected/malformed_warning_attribute.resi.expected

@@ -0,0 +1,10 @@
+
+  Warning number 47
+  /.../fixtures/malformed_warning_attribute.resi:1:1-9
+
+  1 │ @@warning(123)
+  2 │ 
+  3 │ let x: int
+
+  illegal payload for attribute 'warning'.
+A single string literal is expected

tests/build_tests/super_errors/expected/ppwarning_signature_attribute.resi.expected

@@ -0,0 +1,9 @@
+
+  Warning number 22
+  /.../fixtures/ppwarning_signature_attribute.resi:1:13-19
+
+  1 │ @@ppwarning("hello")
+  2 │ 
+  3 │ let x: int
+
+  hello

tests/build_tests/super_errors/fixtures/malformed_warning_attribute.resi

@@ -0,0 +1,3 @@
+@@warning(123)
+
+let x: int

tests/build_tests/super_errors/fixtures/ppwarning_signature_attribute.resi

@@ -0,0 +1,3 @@
+@@ppwarning("hello")
+
+let x: int

tests/build_tests/super_errors/input.js

@@ -11,7 +11,7 @@ const { bsc } = setup(import.meta.dirname);
 const expectedDir = path.join(import.meta.dirname, "expected");
 
 const fixtures = readdirSync(path.join(import.meta.dirname, "fixtures")).filter(
-  fileName => path.extname(fileName) === ".res",
+  fileName => [".res", ".resi"].includes(path.extname(fileName)),
 );
 
 const prefix = ["-w", "+A", "-bs-jsx", "4"];