index variable is a string but is used as a dict ("string indices must be integers")

[smiranda]

rethinkdb-python/rethinkdb/_index_rebuild.py

Line 129 in ecf1dd6

query.db(index["db"])

This happened to me when I killed a reindexation process than started again: the code throws the error "string indices must be integers" and i found is in that line.

To workaround I commented that part of the script and ran. Later I plan to manually delete the temporary index.

[lsabi]

Probably it's due to how the index is saved during the reindexation.

We'll give it a look, but can you provide some more context on how to reproduce it? Thanks

[smiranda]

Hello @lsabi , thanks for the reply.

I think it boils down to this. This command returns a list of strings and not a list of objects. So index is a string.

for index in options.retryQuery(
            "list indexes on %s.%s" % (db, table),
            query.db(db).table(table).index_list(),
        ):

Therefore this other command which is inside of the loops probably needs to be modifed as such:

options.retryQuery(
                    "drop index: %s.%s:%s" % (db, table, index),
                    query.db(index["db"]) # replace index["db"] with db
                    .table(index["table"]) # replace index["table"] with table
                    .index_drop(index["name"]), # replace index["name"] with index
                )

So during indexation rethinkDB creates "$reql_temp_index$" for the indexes it's reindexing. If you interrupt the reindexation these indexes will stay there. The existence of these indexes in this python script I referred triggers this cleanup code. So this cleanup code probably runs rarely, and it crashes.

If you see line

rethinkdb-python/rethinkdb/_index_rebuild.py

Line 126 in ecf1dd6

if index.startswith(TMP_INDEX_PREFIX):

it means the var index was already expected to be a string, not a dict, as it's being used in lines 129,130 and 131. So it just seems a typo.

[lsabi]

I'll try to dig into it as soon as I have some spare time to dedicate.

In the meantime I would keep it open. If you have more feedbacks, just right them here.