Skip to content

Commit 630fa8c

Browse files
author
Grace Calianese
committed
remove commented out code, update method implementation
1 parent 28d8890 commit 630fa8c

2 files changed

Lines changed: 9 additions & 14 deletions

File tree

json/src/main/java/com/basistech/rosette/apimodel/jackson/recordsimilaritydeserializers/RecordSimilarityDeserializerUtilities.java

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -66,15 +66,16 @@ public static RecordSimilarityResult parseResult(JsonNode node, JsonParser jsonP
6666
.build();
6767
}
6868

69-
static Map<String, RecordSimilarityField> parseRecordForResponse(JsonNode jsonNode, JsonParser jsonParser) throws IOException {
69+
static Map<String, RecordSimilarityField> parseRecordForResponse(JsonNode jsonNode, JsonParser jsonParser) {
7070
final Map<String, RecordSimilarityField> recordMap = new HashMap<>();
71-
final Iterator<Map.Entry<String, JsonNode>> recordsIterator = jsonNode.fields();
72-
while (recordsIterator.hasNext()) {
73-
final Map.Entry<String, JsonNode> recordEntry = recordsIterator.next();
74-
final String fieldName = recordEntry.getKey();
75-
RecordSimilarityField rsf = jsonNode.get(fieldName).traverse(jsonParser.getCodec()).readValueAs(UnknownField.class);
76-
recordMap.put(fieldName, rsf);
77-
}
71+
jsonNode.fields().forEachRemaining(entry -> {
72+
String fieldName = entry.getKey();
73+
try {
74+
recordMap.put(fieldName, jsonNode.get(fieldName).traverse(jsonParser.getCodec()).readValueAs(UnknownField.class));
75+
} catch (IOException e) {
76+
throw new RuntimeException(e);
77+
}
78+
});
7879
return recordMap;
7980
}
8081

json/src/main/java/com/basistech/rosette/apimodel/jackson/recordsimilaritydeserializers/RecordSimilarityResponseDeserializer.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,26 +16,20 @@
1616

1717
package com.basistech.rosette.apimodel.jackson.recordsimilaritydeserializers;
1818

19-
//import com.basistech.rosette.apimodel.recordsimilarity.RecordSimilarityFieldInfo;
2019
import com.basistech.rosette.apimodel.recordsimilarity.RecordSimilarityResponse;
2120
import com.basistech.rosette.apimodel.recordsimilarity.RecordSimilarityResult;
2221
import com.fasterxml.jackson.core.JsonParser;
23-
//import com.fasterxml.jackson.core.type.TypeReference;
2422
import com.fasterxml.jackson.databind.DeserializationContext;
2523
import com.fasterxml.jackson.databind.JsonNode;
2624
import com.fasterxml.jackson.databind.deser.std.StdDeserializer;
2725

2826
import java.io.IOException;
2927
import java.util.ArrayList;
3028
import java.util.List;
31-
//import java.util.Map;
3229
import java.util.Optional;
3330

3431
public class RecordSimilarityResponseDeserializer extends StdDeserializer<RecordSimilarityResponse> {
3532

36-
// private static final TypeReference<Map<String, RecordSimilarityFieldInfo>> FIELDS_TYPE_REFERENCE = new TypeReference<>() {
37-
// };
38-
3933
public RecordSimilarityResponseDeserializer() {
4034
super(RecordSimilarityResponse.class);
4135
}

0 commit comments

Comments
 (0)