RLPNC-7516: Removed default value for scoreIfNull

Author: fhasanaj

json/src/test/java/com/basistech/rosette/apimodel/RecordSimilarityRequestTest.java

@@ -42,7 +42,7 @@ class RecordSimilarityRequestTest {
 
     private static final ObjectMapper MAPPER = ApiModelMixinModule.setupObjectMapper(new ObjectMapper());
 
-    private static final String EXPECTED_JSON = "{\"fields\":{\"addr\":{\"type\":\"rni_address\",\"weight\":0.5,\"scoreIfNull\":-1.0},\"dob\":{\"type\":\"rni_date\",\"weight\":0.2,\"scoreIfNull\":-1.0},\"primaryName\":{\"type\":\"rni_name\",\"weight\":0.5,\"scoreIfNull\":-1.0},\"dob2\":{\"type\":\"rni_date\",\"weight\":0.1,\"scoreIfNull\":-1.0}},\"properties\":{\"threshold\":0.7,\"includeExplainInfo\":true},\"records\":{\"left\":[{\"addr\":\"123 Roadlane Ave\",\"dob\":\"1993-04-16\",\"primaryName\":{\"text\":\"Ethan R\",\"entityType\":\"PERSON\",\"language\":\"eng\",\"languageOfOrigin\":\"eng\",\"script\":\"Latn\"},\"dob2\":{\"date\":\"1993/04/16\"}},{\"dob\":{\"date\":\"1993-04-16\"},\"primaryName\":{\"text\":\"Evan R\"}}],\"right\":[{\"dob\":{\"date\":\"1993-04-16\"},\"primaryName\":{\"text\":\"Seth R\",\"language\":\"eng\"}},{\"addr\":{\"address\":\"123 Roadlane Ave\"},\"dob\":{\"date\":\"1993-04-16\"},\"primaryName\":\"Ivan R\",\"dob2\":{\"date\":\"1993/04/16\"}}]}}";
+    private static final String EXPECTED_JSON = "{\"fields\":{\"addr\":{\"type\":\"rni_address\",\"weight\":0.5,\"scoreIfNull\":null},\"dob\":{\"type\":\"rni_date\",\"weight\":0.2,\"scoreIfNull\":null},\"primaryName\":{\"type\":\"rni_name\",\"weight\":0.5,\"scoreIfNull\":null},\"dob2\":{\"type\":\"rni_date\",\"weight\":0.1,\"scoreIfNull\":null}},\"properties\":{\"threshold\":0.7,\"includeExplainInfo\":true},\"records\":{\"left\":[{\"addr\":\"123 Roadlane Ave\",\"dob\":\"1993-04-16\",\"primaryName\":{\"text\":\"Ethan R\",\"entityType\":\"PERSON\",\"language\":\"eng\",\"languageOfOrigin\":\"eng\",\"script\":\"Latn\"},\"dob2\":{\"date\":\"1993/04/16\"}},{\"dob\":{\"date\":\"1993-04-16\"},\"primaryName\":{\"text\":\"Evan R\"}}],\"right\":[{\"dob\":{\"date\":\"1993-04-16\"},\"primaryName\":{\"text\":\"Seth R\",\"language\":\"eng\"}},{\"addr\":{\"address\":\"123 Roadlane Ave\"},\"dob\":{\"date\":\"1993-04-16\"},\"primaryName\":\"Ivan R\",\"dob2\":{\"date\":\"1993/04/16\"}}]}}";
     private static final RecordSimilarityRequest EXPECTED_REQUEST = RecordSimilarityRequest.builder()
             .fields(Map.of(
                     "primaryName", RecordSimilarityFieldInfo.builder().type(RecordFieldType.NAME).weight(0.5).build(),

model/src/main/java/com/basistech/rosette/apimodel/recordsimilarity/RecordSimilarityFieldInfo.java

@@ -29,13 +29,10 @@
 @Builder
 @Value
 public class RecordSimilarityFieldInfo {
-    // The default setting for scoreIfNull, which disables this feature
-    private static final double DEFAULT_SCORE_IF_NULL = -1.0;
     @NotNull @Valid RecordFieldType type;
     Double weight;
     /**
      * the score that this field should return if the field is null in a record
      */
-    @Builder.Default
-    @NotNull @Valid Double scoreIfNull = DEFAULT_SCORE_IF_NULL;
+    @NotNull @Valid Double scoreIfNull;
 }