Merge pull request #84 from rosette-api/WS-3224-1.30-release

Ws 3224 1.30 release

Author: Katsuya-Tomioka

examples/record_similarity.php

@@ -32,7 +32,7 @@
             "primaryName" => array("text" => "Ethan R", "language" => "eng", "script" => "Latn", "entityType" => "PERSON", "languageOfOrigin" => "eng"),
             "dob" => "1993-04-16",
             "addr" => "123 Roadlane Ave",
-            "dob2" => array("date" => "1993/04/16")
+            "dob2" => array("date" => "04161993", "format" => "MMddyyyy")
         ),
         array(
             "dob" => array("date" => "1993-04-16"),
@@ -47,7 +47,7 @@
         array(
             "dob" => array("date" => "1993-04-16"),
             "primaryName" => "Ivan R",
-            "addr" => array("address" => "123 Roadlane Ave"),
+            "addr" => array("houseNumber" => "123", "road" => "Roadlane Ave"),
             "dob2" => array("date" => "1993/04/16")
         )
 

source/rosette/api/RecordSimilarityParameters.php

@@ -61,18 +61,6 @@ public function __construct(array $fields, array $properties, array $records)
      */
     public function validate(): void
     {
-        if (empty($this->fields)) {
-            throw new RosetteException(
-                'Required record similarity parameter not supplied: fields',
-                RosetteException::$BAD_REQUEST_FORMAT
-            );
-        }
-        if (empty($this->properties)) {
-            throw new RosetteException(
-                'Required record similarity parameter not supplied: properties',
-                RosetteException::$BAD_REQUEST_FORMAT
-            );
-        }
         if (empty($this->records)) {
             throw new RosetteException(
                 'Required record similarity parameter not supplied: records',

spec/rosette/api/RecordSimilarityParametersSpec.php

@@ -14,18 +14,6 @@ public function it_passes_validation($fields, $properties, $records)
         $this->shouldNotThrow(RosetteConstants::$RosetteExceptionFullClassName)->duringValidate();
     }
 
-    public function it_has_fields_undefined($fields, $properties, $records)
-    {
-        $this->beConstructedWith((array)null, (array)$properties, (array)$records);
-        $this->shouldThrow(RosetteConstants::$RosetteExceptionFullClassName)->duringValidate();
-    }
-
-    public function it_has_properties_undefined($fields, $properties, $records)
-    {
-        $this->beConstructedWith((array)$fields, (array)null, (array)$records);
-        $this->shouldThrow(RosetteConstants::$RosetteExceptionFullClassName)->duringValidate();
-    }
-
     public function it_has_records_undefined($fields, $properties, $records)
     {
         $this->beConstructedWith((array)$fields, (array)$properties, (array)null);