Skip to content

Commit ca94e8d

Browse files
authored
Merge pull request #67 from ruby/fix-nightly-job
Fix wrong migration result about nightly tag
2 parents bd7183b + 6cee188 commit ca94e8d

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

.github/actions/build_image/action.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,11 @@ runs:
3939
ubuntu_version=${{ inputs.ubuntu_version }} \
4040
arch=${{ inputs.arch }} \
4141
image_version_suffix=${{ inputs.image_version_suffix }} \
42-
${{ inputs.nightly }}nightly=yes${{ inputs.nightly }} \
42+
nightly=${{ inputs.nightly }} \
4343
tag_suffix=${{ inputs.tag_suffix }} \
4444
target=${{ inputs.target }} \
4545
latest_tag=${{ inputs.latest_tag }}
4646
shell: bash
4747
- name: List images
4848
run: docker images
49-
shell: bash
49+
shell: bash

.github/actions/push_image/action.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ runs:
2727
rake docker:push ruby_version=${{ inputs.ruby_version }} \
2828
ubuntu_version=${{ inputs.ubuntu_version }} \
2929
image_version_suffix=${{ inputs.image_version_suffix }} \
30-
${{ inputs.nightly }}nightly=yes${{ inputs.nightly }} \
30+
nightly=${{ inputs.nightly }} \
3131
tag_suffix=${{ inputs.tag_suffix }} \
3232
latest_tag=${{ inputs.latest_tag }}
33-
shell: bash
33+
shell: bash

Rakefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ namespace :docker do
170170
end
171171

172172
def each_nightly_tag(ruby_version, tags)
173-
return [] unless ENV.key?('nightly') && ruby_version.start_with?('master:')
173+
return [] unless (ENV('nightly') == 'true') && ruby_version.start_with?('master:')
174174
commit_hash = ruby_version.split(":")[1]
175175
commit_hash_re = /\b#{Regexp.escape(commit_hash)}\b/
176176
image_name = tags.find {|x| x.match? commit_hash_re }

0 commit comments

Comments
 (0)