added typecheck for complex

Author: sampersand

core/kernel.rbs

@@ -501,7 +501,7 @@ module Kernel : BasicObject
                    | (String real_or_both, ?exception: true) -> Complex
                    | (untyped real_or_both, exception: bool) -> Complex?
                    | (Numeric | String real, Numeric | String imag, ?exception: true) -> Complex
-                   | (Numeric | String real, Integer | Float | Rational | Complex imag, exception: bool) -> Complex
+                   | (Numeric | String real, Integer | Float | Rational | Complex imag, exception: bool) -> Complex?
                    | (Numeric | String real, untyped imag, exception: bool) -> Complex?
 
   # <!--

test/stdlib/Kernel_test.rb

@@ -62,21 +62,25 @@ def test_Complex
                        Kernel, :Complex, real_untype, exception: false
     end
 
-    with '1', 1, 1r, 1.0, (1+0i), numeric do |real|
-      with '2', 2, 2r, 2.0, (2+0i), numeric do |imag|
+    numeric_fail = Class.new(Numeric) { def to_c = fail }.new
+
+    with '1', 1, 1r, 1.0, (1+0i), numeric, numeric_fail do |real|
+      with '2', 2, 2r, 2.0, (2+0i), numeric, numeric_fail do |imag|
         # (Numeric | String real, Numeric | String imag, ?exception: true) -> Complex
-        assert_send_type "(Numeric | String, Numeric | String) -> Complex",
-                         Kernel, :Complex, real, imag
-        assert_send_type "(Numeric | String, Numeric | String, exception: true) -> Complex",
-                         Kernel, :Complex, real, imag, exception: true
+        if real != numeric_fail && imag != numeric_fail
+          assert_send_type "(Numeric | String, Numeric | String) -> Complex",
+                           Kernel, :Complex, real, imag
+          assert_send_type "(Numeric | String, Numeric | String, exception: true) -> Complex",
+                           Kernel, :Complex, real, imag, exception: true
+        end
 
         # Complex has an awkward edgecase where `exception: false` will unconditionally return `nil`
         # if the imaginary argument is not one of the builtin `Numeric`s. Oddly enough, it's not for
         # the `real` one...
         case imag
         when Integer, Float, Rational, Complex
           # (Numeric | String real, Integer | Float | Rational | Complex imag, exception: bool) -> Complex
-          assert_send_type "(Numeric | String, Integer | Float | Rational | Complex, exception: bool) -> Complex",
+          assert_send_type "(Numeric | String, Integer | Float | Rational | Complex, exception: bool) -> Complex?",
                            Kernel, :Complex, real, imag, exception: false
         end
       end

test/typecheck/complex/Steepfile

@@ -0,0 +1,7 @@
+D = Steep::Diagnostic
+
+target :test do
+  signature "."
+  check "."
+  configure_code_diagnostics(D::Ruby.all_error)
+end

test/typecheck/complex/test.rb

@@ -0,0 +1,41 @@
+class Raises
+  def to_c = fail
+end
+
+class RaisesNumeric < Numeric
+  def to_c = fail
+end
+
+Complex(1) #: Complex
+Complex(1.23) #: Complex
+Complex(1r) #: Complex
+Complex(1i) #: Complex
+Complex(1ri) #: Complex
+Complex(Numeric.new) #: Complex
+Complex('1+2i') #: Complex
+
+Complex(1, exception: true) #: Complex
+Complex(1.23, exception: true) #: Complex
+Complex(1r, exception: true) #: Complex
+Complex(1i, exception: true) #: Complex
+Complex(1ri, exception: true) #: Complex
+Complex(Numeric.new, exception: true) #: Complex
+Complex("1+2i", exception: true) #: Complex
+
+Complex(Raises.new, exception: false) #: nil
+Complex(RaisesNumeric.new, exception: false) #: nil
+Complex('a', exception: false) #: nil
+
+Complex(1, 1) #: Complex
+Complex(1.23, 1.23) #: Complex
+Complex(1r, 1r) #: Complex
+Complex(1i, 1i) #: Complex
+Complex(1ri, 1ri) #: Complex
+Complex(Numeric.new, Numeric.new) #: Complex
+Complex('1+2i', '1+2i') #: Complex
+Complex(2, '1+2i') #: Complex
+
+Complex(1, Raises.new, exception: false) #: nil
+Complex(RaisesNumeric.new, 2, exception: false) #: nil
+Complex('a', 3, exception: false) #: nil
+Complex(2, :untyped, exception: false) #: nil

test/typecheck/complex/test.rbs

@@ -0,0 +1,7 @@
+class Raises
+  def to_c: () -> bot
+end
+
+class RaisesNumeric < Numeric
+  def to_c: () -> bot
+end