Skip to content

Refactor Requests controller: too many instance variables #5557

@stefannibrasil

Description

@stefannibrasil

Summary

In #5543, I added one more variable there. I didn't want to refactor the controller since the PR was already too big and it's a good practice to refactor in a separate stream of work.

Things to consider

Since the variables are for the views, we can use a view object instead to keep the controller cleaner.

Criteria for Completion

  • Everything works as before
  • Controller is cleaner

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions