Skip to content

Commit 1f70165

Browse files
committed
Use a new no_force query modifier for check_representability
These queries appear to have been using `anon` for its side-effect of making them ineligible for forcing. According to their comments and also `tests/incremental/issue-61323.rs`, these queries want to avoid forcing so that if a cycle does occur, the whole cycle will be on the query stack for the cycle handler to find.
1 parent 5d0a0f3 commit 1f70165

1 file changed

Lines changed: 10 additions & 0 deletions

File tree

src/queries/incremental-compilation-in-detail.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -418,6 +418,13 @@ deal with all of the above but so far that seemed like more trouble than it woul
418418

419419
## Query modifiers
420420

421+
> FIXME: Make [`rustc_middle::query::modifiers`] the home for query modifier documentation,
422+
> and migrate all other useful modifier docs there after verifying that they are still accurate.
423+
424+
[`rustc_middle::query::modifiers`]:
425+
https://doc.rust-lang.org/nightly/nightly-rustc/rustc_middle/query/modifiers/index.html
426+
427+
421428
The query system allows for applying [modifiers][mod] to queries.
422429
These modifiers affect certain aspects of how the system treats the query with
423430
respect to incremental compilation:
@@ -437,6 +444,9 @@ respect to incremental compilation:
437444
as an optimization because the system can skip recording dependencies in
438445
the first place.
439446

447+
- `no_force` - Never "force" the dep nodes for this query, even if the query's
448+
key type is recoverable.
449+
440450
- `no_hash` - Applying `no_hash` to a query tells the system to not compute
441451
the fingerprint of the query's result.
442452
This has two consequences:

0 commit comments

Comments
 (0)