fix: input instead of env

Author: iowillhoit

.github/actions/determineNodeVersions/action.yml

@@ -4,6 +4,9 @@ inputs:
   nodeVersionOverride:
     description: Set node to a specific Semver version
     required: false
+  nodeDisableVersions:
+    description: A string of major version(s) to disable (18 or 18,23)
+    required: false
 outputs:
   nodeVersions:
     description: Node versions to be consumed by a workflow matrix
@@ -27,4 +30,6 @@ runs:
       shell: bash
       id: node-versions
       run: node "$GITHUB_ACTION_PATH/dist/index.js"
+      with:
+        nodeDisableVersions: ${{ inputs.nodeDisableVersions }}
 

.github/actions/determineNodeVersions/src/main.ts

@@ -5,7 +5,7 @@
  * For full license text, see LICENSE.txt file in the repo root or https://opensource.org/licenses/BSD-3-Clause
  */
 
-import { setFailed, setOutput, notice } from '@actions/core';
+import { setFailed, getInput, setOutput, notice } from '@actions/core';
 
 type VersionData = {
     start: string;
@@ -30,11 +30,9 @@ export const getVersions = async () => {
     // This will ensure that the unit tests run on the same version that will be shipped
     const installedNode = process.versions.node;
 
-    console.log("disabled 23:", process.env.NODE_DISABLE_VERSION_23);
-
-    // Support disabling certain versions via an environment variable
-    // They will be named like `NODE_DISABLE_VERSION_18` and will be set to `true`
-    const disabledVersions = Object.keys(process.env).filter((env) => env.startsWith('NODE_DISABLE_VERSION_')).map((env) => env.replace('NODE_DISABLE_VERSION_', ''));
+    // Comma separated list of major versions to disable
+    // For example: Set `NODE_DISABLE_VERSIONS` to `18,23`
+    const disableVersions = getInput('nodeDisableVersions').split(',');
 
     const today = new Date();
 
@@ -46,9 +44,9 @@ export const getVersions = async () => {
             return today >= startDate && today <= endDate;
         })
         .map((version) => version.replace('v', ''))
-        // Remove versions that are disabled via env vars
+        // Remove versions that are disabled via input (via env var)
         .filter((version) => {
-            if (disabledVersions.includes(version)) {
+            if (disableVersions.includes(version)) {
                 notice(`Node version ${version} is disabled via env var`);
                 return false;
             }

.github/workflows/unitTestsLinux.yml

@@ -17,6 +17,7 @@ jobs:
         id: determine-node-versions
         with:
           nodeVersionOverride: ${{ vars.NODE_VERSION_OVERRIDE }} # default is 'lts/*'
+          nodeDisableVersions: ${{ vars.NODE_DISABLE_VERSIONS }}
 
   prevent-typescript-dependency:
     if: ${{ inputs.skipTsDepCheck == false }}

.github/workflows/unitTestsWindows.yml

@@ -11,6 +11,7 @@ jobs:
         id: determine-node-versions
         with:
           nodeVersionOverride: ${{ vars.NODE_VERSION_OVERRIDE }} # default is 'lts/*'
+          nodeDisableVersions: ${{ vars.NODE_DISABLE_VERSIONS }}
 
   windows-unit-tests:
     needs: determine-node-versions