chore: remove --username flag

Author: WillieRuemmele

command-snapshot.json

@@ -4,7 +4,7 @@
     "command": "org:create:agent-user",
     "flagAliases": [],
     "flagChars": ["o"],
-    "flags": ["api-version", "base-username", "first-name", "flags-dir", "json", "last-name", "target-org", "username"],
+    "flags": ["api-version", "base-username", "first-name", "flags-dir", "json", "last-name", "target-org"],
     "plugin": "@salesforce/plugin-org"
   },
   {

messages/create_agent_user.md

@@ -1,33 +1,32 @@
 # summary
 
-Create an agent user for use with Agentforce.
+Create a default_agent_user for use with Agentforce and agentscript.
 
 # description
 
-Agent users are specialized user accounts designed to be used as default_agent_user in AgentScript. These users are automatically configured with the Einstein Agent User profile and required Agentforce permission sets.
+Agent users are specialized user accounts designed to be used as default_agent_user in AgentScript. These users are
+automatically configured with the Einstein Agent User profile and required Agentforce permission sets.
 
 The command automatically:
 
 - Checks that agent user licenses are available in your org
-- Generates a globally unique username (or uses the one you specify)
+- Generates a globally unique username with a GUID for uniqueness
 - Creates the user with the Einstein Agent User profile
-- Assigns required permission sets: AgentforceServiceAgentBase, AgentforceServiceAgentUser, EinsteinGPTPromptTemplateUser
+- Assigns required permission sets: AgentforceServiceAgentBase, AgentforceServiceAgentUser,
+  EinsteinGPTPromptTemplateUser
 - Infers locale settings (timezone, language) from the current user
 
 To assign additional permission sets after creation, use: sf org assign permset
 
-The command performs comprehensive validation and provides clear error messages to help diagnose and resolve any issues during the creation process.
+The command performs comprehensive validation and provides clear error messages to help diagnose and resolve any issues
+during the creation process.
 
 # examples
 
 - Create an agent user with auto-generated username:
 
   <%= config.bin %> <%= command.id %> --target-org myorg
 
-- Create an agent user with a specific username:
-
-  <%= config.bin %> <%= command.id %> --target-org myorg --username service.agent@company.com
-
 - Create an agent user with a base username pattern (GUID will be appended):
 
   <%= config.bin %> <%= command.id %> --target-org myorg --base-username service-agent@corp.com
@@ -36,38 +35,22 @@ The command performs comprehensive validation and provides clear error messages
 
   <%= config.bin %> <%= command.id %> --target-org myorg --first-name Service --last-name Agent
 
-- Assign additional permission sets after creation:
-
-  <%= config.bin %> <%= command.id %> --target-org myorg
-  <%= config.bin %> org assign permset --name CustomPermSet --target-org myorg --on-behalf-of <username>
-
 # flags.target-org.summary
 
 Username or alias of the target org where the agent user will be created.
 
-# flags.username.summary
-
-Username for the agent user. Auto-generated if not specified.
-
-# flags.username.description
-
-If you specify a username, it must be globally unique across the entire Salesforce universe (all orgs, sandboxes, and scratch orgs). The command will verify the username doesn't already exist before attempting to create the user.
-
-If not specified (and no --base-username provided), the command automatically generates a unique username like: agent.user.a1b2c3d4e5f6@your-org-domain.com
-
-This flag is mutually exclusive with --base-username.
-
 # flags.base-username.summary
 
 Base username pattern. A GUID will be appended to ensure global uniqueness.
 
 # flags.base-username.description
 
-Specify a base username in email format (e.g., service-agent@corp.com). The command will append a 12-character GUID to ensure the username is globally unique across all Salesforce orgs and sandboxes.
+Specify a base username in email format (e.g., service-agent@corp.com). The command will append a 12-character GUID to
+ensure the username is globally unique across all Salesforce orgs and sandboxes.
 
 Example: "service-agent@corp.com" becomes "service-agent.a1b2c3d4e5f6@corp.com"
 
-This flag is mutually exclusive with --username. If neither --username nor --base-username is specified, the command auto-generates: agent.user.<GUID>@your-org-domain.com
+If not specified, the command auto-generates: agent.user.<GUID>@your-org-domain.com
 
 # flags.first-name.summary
 

src/commands/org/create/agent-user.ts

@@ -37,15 +37,9 @@ export default class OrgCreateAgentUser extends SfCommand<AgentUserCreateRespons
   public static readonly flags = {
     'target-org': Flags.requiredOrg(),
     'api-version': Flags.orgApiVersion(),
-    username: Flags.string({
-      summary: messages.getMessage('flags.username.summary'),
-      description: messages.getMessage('flags.username.description'),
-      exclusive: ['base-username'],
-    }),
     'base-username': Flags.string({
       summary: messages.getMessage('flags.base-username.summary'),
       description: messages.getMessage('flags.base-username.description'),
-      exclusive: ['username'],
     }),
     'first-name': Flags.string({
       summary: messages.getMessage('flags.first-name.summary'),
@@ -62,7 +56,7 @@ export default class OrgCreateAgentUser extends SfCommand<AgentUserCreateRespons
     const connection = flags['target-org'].getConnection(flags['api-version']);
 
     // Generate username
-    const username = await this.generateUsername(connection, flags.username, flags['base-username']);
+    const username = this.generateUsername(connection, flags['base-username']);
     this.log(`Generated username: ${username}`);
 
     // Always check for available agent user licenses
@@ -115,24 +109,8 @@ export default class OrgCreateAgentUser extends SfCommand<AgentUserCreateRespons
     };
   }
 
-  private async generateUsername(
-    connection: Connection,
-    username: string | undefined,
-    baseUsername: string | undefined
-  ): Promise<string> {
-    // If explicit username provided, validate it's unique
-    if (username) {
-      const existingUser = await this.checkUsernameExists(connection, username);
-      if (existingUser) {
-        throw new SfError(
-          `Username "${username}" already exists in the Salesforce universe. Usernames must be globally unique.`,
-          'UsernameExistsError',
-          ['Choose a different username', 'Omit --username to auto-generate a unique username']
-        );
-      }
-      return username;
-    }
-
+  // eslint-disable-next-line class-methods-use-this
+  private generateUsername(connection: Connection, baseUsername: string | undefined): string {
     // Generate username with GUID
     const guid = randomUUID().replace(/-/g, '').substring(0, 12);
 
@@ -154,24 +132,13 @@ export default class OrgCreateAgentUser extends SfCommand<AgentUserCreateRespons
     const orgUsername = orgIdentity.username;
     if (!orgUsername) {
       throw new SfError('Unable to determine org username for generating agent user username', 'OrgUsernameError', [
-        'Specify an explicit --username or --base-username',
+        'Specify a --base-username',
       ]);
     }
     const domain = orgUsername.split('@')[1];
     return `agent.user.${guid}@${domain}`;
   }
 
-  private async checkUsernameExists(connection: Connection, username: string): Promise<boolean> {
-    try {
-      const result = await connection.query<{ Id: string }>(`SELECT Id FROM User WHERE Username = '${username}'`);
-      return result.totalSize > 0;
-    } catch (error) {
-      // If query fails, assume username might exist to be safe
-      this.warn(`Unable to verify username uniqueness: ${error instanceof Error ? error.message : String(error)}`);
-      return false;
-    }
-  }
-
   private async checkAgentUserLicenses(connection: Connection): Promise<void> {
     // Query the Einstein Agent User profile to get its associated license
     const profileResult = await connection.query<{

test/unit/org/create/agent-user.test.ts

@@ -24,24 +24,11 @@ describe('org:create:agent-user', () => {
     expect(OrgCreateAgentUser.summary).to.exist;
     expect(OrgCreateAgentUser.flags).to.exist;
     expect(OrgCreateAgentUser.flags['target-org']).to.exist;
-    expect(OrgCreateAgentUser.flags.username).to.exist;
     expect(OrgCreateAgentUser.flags['base-username']).to.exist;
     expect(OrgCreateAgentUser.flags['first-name']).to.exist;
     expect(OrgCreateAgentUser.flags['last-name']).to.exist;
   });
 
-  it('should export AgentUserCreateResponse type', () => {
-    // Type is exported from the module
-    const response: import('../../../../src/commands/org/create/agent-user.js').AgentUserCreateResponse = {
-      userId: '005xx000000000001',
-      username: 'test@example.com',
-      profileId: '00exx0000000001',
-      permissionSetsAssigned: [],
-      permissionSetErrors: [],
-    };
-    expect(response).to.exist;
-  });
-
   it('should throw InvalidBaseUsernameError for invalid base username format', () => {
     // This test validates the error without needing a real org
     const error = new SfError(