feat(W-17369132): reflect feat change to use Package2Version instead of MetadataP… (#984)

* feat: reflect feat change to use Package2Version instead of MetadataPackageVerison API for retrieve

* feat: update help text to indicate this is currently for only conversion 2GPs

* feat: unhide package retrieve and rev vers for saleseforce/core and salesforce/packaging

* feat: unhide package retrieve and rev vers for saleseforce/core and salesforce/packaging

* feat: update schema iwth DeveloperUsePkgZip

* feat: remove DeveloperUsePkgZip from report schema

* Revert "feat: remove DeveloperUsePkgZip from report schema"

This reverts commit e2c3e61.

* chore: bump packaging

* feat: remove DeveloperUsePkgZip from report schema

---------

Co-authored-by: Willie Ruemmele <willieruemmele@gmail.com>

Author: KSCCO

command-snapshot.json

@@ -417,9 +417,9 @@
   {
     "alias": [],
     "command": "package:version:retrieve",
-    "flagAliases": ["apiversion", "targetusername", "u"],
-    "flagChars": ["d", "o", "p"],
-    "flags": ["api-version", "flags-dir", "json", "loglevel", "output-dir", "package", "target-org"],
+    "flagAliases": ["apiversion", "targetdevhubusername"],
+    "flagChars": ["d", "p", "v"],
+    "flags": ["api-version", "flags-dir", "json", "loglevel", "output-dir", "package", "target-dev-hub"],
     "plugin": "@salesforce/plugin-packaging"
   },
   {

messages/package_pushupgrade_schedule.md

@@ -40,7 +40,7 @@ Filename of the CSV file that contains the list of subscriber org IDs that need
 
 # flags.org-file.description
 
-The file must contain one org per line. The org ID must be the only value in each row. 
+The file must contain one org per line. The org ID must be the only value in each row.
 All listed orgs must have a package version installed in their org that is lower than the package version you specified for the --package flag.
 
 # flags.org-list.summary

messages/package_version_retrieve.md

@@ -1,22 +1,18 @@
 # summary
 
-Retrieve package metadata for a specified package version.
+Retrieve package metadata for a specified package version. Package metadata can be retrieved for converted second-generation managed package versions only.
 
 # description
 
 Retrieving a package version downloads the metadata into the directory you specify.
 
-You can retrieve metadata for a second- or first-generation managed package, or an unlocked package.
-
 Specify the subscriber package version ID (starts with 04t) and the path to an empty directory when you run this command.
 
 # examples
 
-- Retrieve package metadata for a subscriber package version ID (starts with 04t) into my-folder/ within your Salesforce DX project directory:
-
-  <%= config.bin %> <%= command.id %> --package 04t... --output-dir my-folder –-target-org my-scratch
+- Retrieve package metadata for a converted subscriber package version ID (starts with 04t) into my-folder/ within your Salesforce DX project directory:
 
-  If you omit --target-org, this command runs against your default org.
+  <%= config.bin %> <%= command.id %> --package 04t... --output-dir my-folder –-target-dev-hub my-devhub
 
 # flags.package.summary
 

package.json

@@ -6,9 +6,9 @@
   "bugs": "https://github.com/forcedotcom/cli/issues",
   "dependencies": {
     "@oclif/core": "^4",
-    "@salesforce/core": "^8.12.0",
+    "@salesforce/core": "^8.15.0",
     "@salesforce/kit": "^3.2.3",
-    "@salesforce/packaging": "^4.7.0",
+    "@salesforce/packaging": "^4.9.0",
     "@salesforce/sf-plugins-core": "^12.2.2",
     "chalk": "^5.4.1"
   },

src/commands/package/version/report.ts

@@ -24,7 +24,13 @@ const messages = Messages.loadMessages('@salesforce/plugin-packaging', 'package_
 const pvlMessages = Messages.loadMessages('@salesforce/plugin-packaging', 'package_version_list');
 const plMessages = Messages.loadMessages('@salesforce/plugin-packaging', 'package_list');
 
-const omissions = ['CodeCoverage', 'HasPassedCodeCoverageCheck', 'Package2', 'HasMetadataRemoved'] as const;
+const omissions = [
+  'CodeCoverage',
+  'HasPassedCodeCoverageCheck',
+  'Package2',
+  'HasMetadataRemoved',
+  'DeveloperUsePkgZip',
+] as const;
 type Omission = (typeof omissions)[number];
 
 export type PackageVersionReportResultModified = Omit<PackageVersionReportResult, Omission> & {

src/commands/package/version/retrieve.ts

@@ -10,7 +10,7 @@ import {
   Flags,
   loglevel,
   orgApiVersionFlagWithDeprecations,
-  requiredOrgFlagWithDeprecations,
+  requiredHubFlagWithDeprecations,
   SfCommand,
 } from '@salesforce/sf-plugins-core';
 import { Messages } from '@salesforce/core/messages';
@@ -28,15 +28,14 @@ export type FileDownloadEntry = {
 export type PackageVersionRetrieveCommandResult = FileDownloadEntry[];
 
 export class PackageVersionRetrieveCommand extends SfCommand<PackageVersionRetrieveCommandResult> {
-  public static readonly hidden = true;
   public static readonly summary = messages.getMessage('summary');
   public static readonly description = messages.getMessage('description');
   public static readonly examples = messages.getMessages('examples');
   public static readonly requiresProject = true;
   public static readonly flags = {
     loglevel,
     'api-version': orgApiVersionFlagWithDeprecations,
-    'target-org': requiredOrgFlagWithDeprecations,
+    'target-dev-hub': requiredHubFlagWithDeprecations,
     package: Flags.string({
       char: 'p',
       summary: messages.getMessage('flags.package.summary'),
@@ -51,7 +50,7 @@ export class PackageVersionRetrieveCommand extends SfCommand<PackageVersionRetri
 
   public async run(): Promise<PackageVersionRetrieveCommandResult> {
     const { flags } = await this.parse(PackageVersionRetrieveCommand);
-    const connection = flags['target-org'].getConnection(flags['api-version']);
+    const connection = flags['target-dev-hub'].getConnection(flags['api-version']);
     const options = {
       subscriberPackageVersionId: flags.package ?? '',
       destinationFolder: flags['output-dir'],

test/commands/package/packageVersionRetrieve.test.ts

@@ -67,7 +67,7 @@ describe('package:version:retrieve - tests', () => {
   describe('package:version:retrieve', () => {
     it('should display retrieved files', async () => {
       downloadStub.resolves(pkgVersionRetrieveSuccessResult);
-      const cmd = new PackageVersionRetrieveCommand(['-p', myPackageVersion04t, '-o', 'test@dev.org'], config);
+      const cmd = new PackageVersionRetrieveCommand(['-p', myPackageVersion04t, '-v', 'test@dev.org'], config);
       const res = await cmd.run();
       expect(res).to.deep.equal(expectedRetrievedComponents);
     });