Skip to content

Commit cad9947

Browse files
WillieRuemmeleWillieRuemmele
committed
chore: remove unused eslint directives
1 parent b4b16b6 commit cad9947

11 files changed

Lines changed: 66 additions & 115 deletions

File tree

‎src/commands/package/push-upgrade/abort.ts‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ import { PackagePushUpgrade } from '@salesforce/packaging';
1111
Messages.importMessagesDirectoryFromMetaUrl(import.meta.url);
1212
const messages = Messages.loadMessages('@salesforce/plugin-packaging', 'package_pushupgrade_abort');
1313

14-
export interface PackagePushUpgradeAbortResult {
14+
export type PackagePushUpgradeAbortResult = {
1515
success: boolean;
16-
}
16+
};
1717

1818
export class PackagePushUpgradeAbortCommand extends SfCommand<PackagePushUpgradeAbortResult> {
1919
public static readonly summary = messages.getMessage('summary');
@@ -22,7 +22,6 @@ export class PackagePushUpgradeAbortCommand extends SfCommand<PackagePushUpgrade
2222
public static readonly flags = {
2323
'target-dev-hub': Flags.requiredHub(),
2424
'api-version': Flags.orgApiVersion(),
25-
// eslint-disable-next-line sf-plugin/id-flag-suggestions
2625
'push-request-id': Flags.salesforceId({
2726
length: 'both',
2827
char: 'i',
@@ -38,7 +37,6 @@ export class PackagePushUpgradeAbortCommand extends SfCommand<PackagePushUpgrade
3837

3938
const packagePushRequestOptions = { packagePushRequestId: flags['push-request-id'] };
4039

41-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-member-access
4240
const result: boolean = await PackagePushUpgrade.abort(connection, packagePushRequestOptions);
4341

4442
if (result) {

‎src/commands/package/push-upgrade/list.ts‎

Lines changed: 13 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -60,74 +60,61 @@ export class PackagePushRequestListCommand extends SfCommand<PackagePushRequestL
6060
}
6161

6262
logger.debug(`Querying PackagePushRequest records from org ${hubOrg.getOrgId()}`);
63-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-member-access
63+
6464
const results: PackagePushRequestListResultArr = await PackagePushUpgrade.list(connection, {
6565
packageId: flags.package,
6666
status: flags.status as PackagePushStatus | undefined,
6767
scheduledLastDays,
68-
isMigration: flags['show-push-migrations-only']
68+
isMigration: flags['show-push-migrations-only'],
6969
});
7070

7171
if (results.length === 0) {
7272
this.warn('No results found');
7373
} else {
7474
const data = await Promise.all(
7575
results.map(async (record: PackagePushRequestListResult) => {
76-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access
7776
const packagePushRequestId = record?.Id;
78-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
77+
7978
const packagePushRequestOptions = { packagePushRequestId };
8079

81-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-member-access
8280
const totalNumOrgs = await PackagePushUpgrade.getTotalJobs(connection, packagePushRequestOptions);
83-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-member-access
81+
8482
const numOrgsUpgradedFail = await PackagePushUpgrade.getFailedJobs(connection, packagePushRequestOptions);
85-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-member-access
83+
8684
const numOrgsUpgradedSuccess = await PackagePushUpgrade.getSucceededJobs(
8785
connection,
8886
packagePushRequestOptions
8987
);
9088

91-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access
9289
const pv = record?.PackageVersion;
9390
const packageVersionNumber =
94-
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
95-
pv?.MajorVersion != null &&
96-
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
97-
pv?.MinorVersion != null
98-
? // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-member-access
99-
`${pv.MajorVersion}.${pv.MinorVersion}`
100-
: undefined;
91+
pv?.MajorVersion != null && pv?.MinorVersion != null ? `${pv.MajorVersion}.${pv.MinorVersion}` : undefined;
10192

10293
return {
103-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access
10494
Id: record?.Id,
105-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access
10695
PackageVersionId: record?.PackageVersionId,
107-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access
10896
PackageVersionName: pv?.Name,
10997
PackageVersionNumber: packageVersionNumber,
110-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access
98+
11199
Status: record?.Status,
112-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access
100+
113101
ScheduledStartTime: record?.ScheduledStartTime,
114-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access
102+
115103
StartTime: record?.StartTime,
116-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access
104+
117105
EndTime: record?.EndTime,
118-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
106+
119107
NumOrgsScheduled: totalNumOrgs,
120-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
108+
121109
NumOrgsUpgradedFail: numOrgsUpgradedFail,
122-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
110+
123111
NumOrgsUpgradedSuccess: numOrgsUpgradedSuccess,
124112
};
125113
})
126114
);
127115

128116
this.table({ data });
129117
}
130-
// eslint-disable-next-line @typescript-eslint/no-unsafe-return
131118
return results;
132119
}
133120
}

‎src/commands/package/push-upgrade/report.ts‎

Lines changed: 16 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ Messages.importMessagesDirectoryFromMetaUrl(import.meta.url);
2020
const messages = Messages.loadMessages('@salesforce/plugin-packaging', 'package_pushupgrade_report');
2121
const ERROR_LIMIT = 12;
2222

23-
// eslint-disable-next-line @typescript-eslint/no-redundant-type-constituents
2423
export type ReportCommandResult = PackagePushRequestReportResult | null;
2524

2625
export class PackagePushUpgradeReportCommand extends SfCommand<ReportCommandResult> {
@@ -56,39 +55,33 @@ export class PackagePushUpgradeReportCommand extends SfCommand<ReportCommandResu
5655
packagePushRequestOptions.packagePushRequestId
5756
}`
5857
);
59-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-member-access
58+
6059
const records: PackagePushRequestReportResult[] = await PackagePushUpgrade.report(
6160
connection,
6261
packagePushRequestOptions
6362
);
6463

6564
if (records?.length === 1) {
66-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
6765
const record: PackagePushRequestReportResult = records[0];
6866

69-
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
7067
logger.debug(`Found PackagePushRequestReport record: ${record?.Id}`);
7168

72-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-member-access
7369
const totalJobs: number = await PackagePushUpgrade.getTotalJobs(connection, packagePushRequestOptions);
7470

7571
let failedJobs = 0;
7672
let succeededJobs = 0;
7773
let jobFailureReasons: PackagePushRequestReportJobFailuresResult[] | undefined;
7874

79-
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-member-access
8075
if (record?.Status === 'Succeeded' || record?.Status === 'Failed' || record?.Status === 'In Progress') {
81-
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
8276
logger.debug(`PushRequest Status is ${record.Status}, getting job details.`);
83-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-member-access
77+
8478
failedJobs = await PackagePushUpgrade.getFailedJobs(connection, packagePushRequestOptions);
85-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-member-access
79+
8680
succeededJobs = await PackagePushUpgrade.getSucceededJobs(connection, packagePushRequestOptions);
87-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-member-access
81+
8882
jobFailureReasons = await PackagePushUpgrade.getJobFailureReasons(connection, packagePushRequestOptions);
8983
}
9084
this.display(record, totalJobs, succeededJobs, failedJobs, jobFailureReasons);
91-
// eslint-disable-next-line @typescript-eslint/no-unsafe-return
9285
return record;
9386
}
9487
this.warn('No results found');
@@ -105,62 +98,62 @@ export class PackagePushUpgradeReportCommand extends SfCommand<ReportCommandResu
10598
const data = [
10699
{
107100
name: 'Package Name',
108-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access
101+
109102
value: record.PackageVersion.MetadataPackage.Name,
110103
},
111104
{
112105
name: 'Package Version Name',
113-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access
106+
114107
value: record.PackageVersion.Name,
115108
},
116109
{
117110
name: 'Package Version',
118-
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-member-access
111+
119112
value: record.PackageVersion.MajorVersion + '.' + record.PackageVersion.MinorVersion,
120113
},
121114
{
122115
name: 'Namespace',
123-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access
116+
124117
value: record.PackageVersion.MetadataPackage.NamespacePrefix,
125118
},
126119
{
127120
name: 'Package Id',
128-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access
121+
129122
value: record.PackageVersion.MetadataPackageId,
130123
},
131124
{
132125
name: 'Package Version Id',
133-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access
126+
134127
value: record.PackageVersionId,
135128
},
136129
{
137130
name: 'Package Push Request Id',
138-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access
131+
139132
value: record.Id,
140133
},
141134
{
142135
name: 'Status',
143-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access
136+
144137
value: record.Status,
145138
},
146139
{
147140
name: 'Scheduled Start Time',
148-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access
141+
149142
value: record.ScheduledStartTime,
150143
},
151144
{
152145
name: 'Start Time',
153-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access
146+
154147
value: record.StartTime,
155148
},
156149
{
157150
name: 'End Time',
158-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access
151+
159152
value: record.EndTime,
160153
},
161154
{
162155
name: 'Duration Seconds',
163-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access
156+
164157
value: record.DurationSeconds,
165158
},
166159
{
@@ -183,14 +176,12 @@ export class PackagePushUpgradeReportCommand extends SfCommand<ReportCommandResu
183176
this.log('');
184177
const errors: string[] = [];
185178
jobFailureReasons.slice(0, ERROR_LIMIT).forEach((error: PackagePushRequestReportJobFailuresResult) => {
186-
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
187179
errors.push(`(${errors.length + 1}) ${error.ErrorMessage}`);
188180
});
189181
this.styledHeader(chalk.red('Errors'));
190182
this.warn(errors.join('\n'));
191183

192184
if (jobFailureReasons?.length > ERROR_LIMIT) {
193-
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
194185
this.warn(messages.getMessage('truncatedErrors', [this.config.bin, record.Id]));
195186
}
196187
}

‎src/commands/package/push-upgrade/schedule.ts‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@ export class PackagePushScheduleCommand extends SfCommand<PackagePushScheduleRes
7373
const startTime = flags['start-time'];
7474
const isMigration = flags['migrate-to-2gp'];
7575

76-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-member-access
7776
const result: PackagePushScheduleResult = await PackagePushUpgrade.schedule(
7877
conn,
7978
flags.package,
@@ -82,10 +81,8 @@ export class PackagePushScheduleCommand extends SfCommand<PackagePushScheduleRes
8281
isMigration
8382
);
8483

85-
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
8684
this.log(messages.getMessage('output', [result?.PushRequestId, orgList.join(', ')]));
8785

88-
// eslint-disable-next-line @typescript-eslint/no-unsafe-return
8986
return result;
9087
}
9188
}

‎src/commands/package/version/report.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,6 @@ export class PackageVersionReportCommand extends SfCommand<PackageVersionReportR
173173
displayRecords.push(
174174
{
175175
key: '# MetadataFiles',
176-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-member-access
177176
value: record.TotalNumberOfMetadataFiles?.toString() ?? '',
178177
},
179178
{

‎test/commands/package/packagePushUpgradeAbort.test.ts‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@ describe('PackagePushUpgradeAbortCommand', () => {
2222
beforeEach(async () => {
2323
await $$.stubAuths(testOrg);
2424
await config.load();
25-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
25+
2626
logStub = $$.SANDBOX.stub(SfCommand.prototype, 'log');
27-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
27+
2828
abortStub = $$.SANDBOX.stub(PackagePushUpgrade, 'abort');
2929
});
3030

@@ -35,7 +35,7 @@ describe('PackagePushUpgradeAbortCommand', () => {
3535
it('should pass the right parameters to the library', async () => {
3636
const pushRequestId = '0DVxx0000004CCG';
3737
const cmd = new PackagePushUpgradeAbortCommand(['-i', pushRequestId, '-v', testOrg.username], config);
38-
// eslint-disable-next-line @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-member-access
38+
3939
abortStub.resolves(true);
4040
const res = await cmd.run();
4141

@@ -60,7 +60,6 @@ describe('PackagePushUpgradeAbortCommand', () => {
6060
});
6161

6262
it('should throw an error if push-request status is not "Created" or "Pending" or is missing', async () => {
63-
// eslint-disable-next-line @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-member-access
6463
abortStub.rejects(new Error('Abortion is only allowed for "Created" or "Pending" statuses.'));
6564
const cmd = new PackagePushUpgradeAbortCommand(['-i', '0DVxx0000004CCG', '-v', 'test@hub.org'], config);
6665

‎test/commands/package/packagePushUpgradeList.test.ts‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -46,13 +46,13 @@ describe('package:pushupgrade:list - tests', () => {
4646
await $$.stubAuths(testOrg);
4747
await config.load();
4848
sfCommandStubs = stubSfCommandUx($$.SANDBOX);
49-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
49+
5050
listStub = $$.SANDBOX.stub(PackagePushUpgrade, 'list');
51-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
51+
5252
getTotalJobsStub = $$.SANDBOX.stub(PackagePushUpgrade, 'getTotalJobs');
53-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
53+
5454
getFailedJobsStub = $$.SANDBOX.stub(PackagePushUpgrade, 'getFailedJobs');
55-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
55+
5656
getSucceededJobsStub = $$.SANDBOX.stub(PackagePushUpgrade, 'getSucceededJobs');
5757
});
5858

@@ -63,13 +63,13 @@ describe('package:pushupgrade:list - tests', () => {
6363
it('should list the push upgrade requests', async () => {
6464
const packageId = 'dummyPackageId';
6565
const cmd = new PackagePushRequestListCommand(['-v', testOrg.username, '--package', packageId], config);
66-
// eslint-disable-next-line @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-member-access
66+
6767
listStub.resolves(pushUpgradeListSuccess);
68-
// eslint-disable-next-line @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-member-access
68+
6969
getTotalJobsStub.resolves(3);
70-
// eslint-disable-next-line @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-member-access
70+
7171
getFailedJobsStub.resolves(1);
72-
// eslint-disable-next-line @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-member-access
72+
7373
getSucceededJobsStub.resolves(2);
7474

7575
const envSpy = $$.SANDBOX.spy(env, 'setBoolean').withArgs('SF_APPLY_REPLACEMENTS_ON_CONVERT', true);
@@ -86,7 +86,7 @@ describe('package:pushupgrade:list - tests', () => {
8686
it('should handle no results found', async () => {
8787
const packageId = 'dummyPackageId';
8888
const cmd = new PackagePushRequestListCommand(['-v', testOrg.username, '--package', packageId], config);
89-
// eslint-disable-next-line @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-member-access
89+
9090
listStub.resolves([]);
9191

9292
await cmd.run();

0 commit comments

Comments
 (0)