Fixes because of changes regarding Metadata\FeatureAnalyzer.

Author: ThomasNunninger

src/Magic/AbstractCallHandler.php

@@ -31,7 +31,7 @@ public function requiresObjectContext() : bool
 
     protected function getMethodMetadata(string $methodName, ClassMetadata $classMetadata) : ?VirtualMethodMetadata
     {
-        $virtualMethods = $classMetadata->features[VirtualMethods::FEATURES_KEY];
+        $virtualMethods = $classMetadata->features[VirtualMethods::class];
 
         // check for corresponding @method annotation
         if (! array_key_exists($methodName, $virtualMethods)) {

src/Magic/Dispatcher.php

@@ -150,7 +150,7 @@ private function assertGivenParametersMatchMethodSignature(
         ClassMetadata $classMetadata
     )
     {
-        $methodMetadata = $classMetadata->features[VirtualMethods::FEATURES_KEY][$methodName];
+        $methodMetadata = $classMetadata->features[VirtualMethods::class][$methodName];
         $expectedParameterCount = count($methodMetadata->parameters);
 
         $givenParametersCount = count($parameters);
@@ -180,7 +180,7 @@ private function assertCorrectReturnType(
     )
     {
         /** @var VirtualMethodMetadata $virtualMethodMetadata */
-        $virtualMethodMetadata = $classMetadata->features[VirtualMethods::FEATURES_KEY][$methodName];
+        $virtualMethodMetadata = $classMetadata->features[VirtualMethods::class][$methodName];
         $returnType = $virtualMethodMetadata->returnType;
 
         if (! is_null($returnType->declaration())) {

src/Magic/FixtureBuilder.php

@@ -137,7 +137,7 @@ private function executeWith(
     private function getMetadataOfClassToBeBuilt(ClassMetadata $classMetadata) : ?ClassMetadata
     {
         // get name of class to be built
-        $virtualBuildMethod = $classMetadata->features[VirtualMethods::FEATURES_KEY]['build'];
+        $virtualBuildMethod = $classMetadata->features[VirtualMethods::class]['build'];
         $buildClassName = $virtualBuildMethod->returnType->declaration();
 
         if (is_null($buildClassName)) {

tests/PhpUnit/Magic/FixtureBuilderTest.php

@@ -77,7 +77,7 @@ public function it_cannot_handle_a_with_method_if_build_method_is_missing()
         // but the ClassMetadata has no build() method
         /** @var ClassMetadata $classMetadata */
         $classMetadata = clone $classMetadata;
-        unset($classMetadata->features[VirtualMethods::FEATURES_KEY]['build']);
+        unset($classMetadata->features[VirtualMethods::class]['build']);
 
         // when checking if the handler can handle a with method
         $result = $callHandler->canHandle($methodName, $classMetadata, []);
@@ -104,10 +104,10 @@ public function it_cannot_handle_a_with_method_if_builder_method_has_no_return_t
         Assert::true($callHandler->canHandle($methodName, $classMetadata, []));
         // but the ClassMetadata's build() method has no return type
         $classMetadata = clone $classMetadata;
-        $classMetadata->features[VirtualMethods::FEATURES_KEY]['build'] =
-            clone $classMetadata->features[VirtualMethods::FEATURES_KEY]['build'];
+        $classMetadata->features[VirtualMethods::class]['build'] =
+            clone $classMetadata->features[VirtualMethods::class]['build'];
         Reflection::setPropertyValue(
-            $classMetadata->features[VirtualMethods::FEATURES_KEY]['build'],
+            $classMetadata->features[VirtualMethods::class]['build'],
             'returnType',
             new DataTypeMetadata(null)
         );

tests/Resources/TestCase.php

@@ -25,7 +25,7 @@ protected function analyzeFeatures(ClassMetadata $classMetadata)
         $featureAnalyzers = Configuration::featureAnalyzers();
 
         foreach ($featureAnalyzers as $analyzer) {
-            $key = $analyzer->name();
+            $key = get_class($analyzer);
             $metadata =  $analyzer->extractMetadata($classMetadata);
 
             $classMetadata->features[$key] = $metadata;