Skip to content

Commit 58f67be

Browse files
robimarkogregkh
authored andcommitted
mmc: core: disable TRIM on Kingston EMMC04G-M627
commit f1738a1 upstream. It seems that Kingston EMMC04G-M627 despite advertising TRIM support does not work when the core is trying to use REQ_OP_WRITE_ZEROES. We are seeing I/O errors in OpenWrt under 6.1 on Zyxel NBG7815 that we did not previously have and tracked it down to REQ_OP_WRITE_ZEROES. Trying to use fstrim seems to also throw errors like: [93010.835112] I/O error, dev loop0, sector 16902 op 0x3:(DISCARD) flags 0x800 phys_seg 1 prio class 2 Disabling TRIM makes the error go away, so lets add a quirk for this eMMC to disable TRIM. Signed-off-by: Robert Marko <robimarko@gmail.com> Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20230619193621.437358-1-robimarko@gmail.com Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent dc77335 commit 58f67be

1 file changed

Lines changed: 7 additions & 0 deletions

File tree

drivers/mmc/core/quirks.h

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,13 @@ static const struct mmc_fixup mmc_blk_fixups[] = {
9090
MMC_FIXUP("VZL00M", CID_MANFID_SAMSUNG, CID_OEMID_ANY, add_quirk_mmc,
9191
MMC_QUIRK_SEC_ERASE_TRIM_BROKEN),
9292

93+
/*
94+
* Kingston EMMC04G-M627 advertises TRIM but it does not seems to
95+
* support being used to offload WRITE_ZEROES.
96+
*/
97+
MMC_FIXUP("M62704", CID_MANFID_KINGSTON, 0x0100, add_quirk_mmc,
98+
MMC_QUIRK_TRIM_BROKEN),
99+
93100
/*
94101
* On Some Kingston eMMCs, performing trim can result in
95102
* unrecoverable data conrruption occasionally due to a firmware bug.

0 commit comments

Comments
 (0)