Target: Add sound effect getter

Author: adazem009

include/scratchcpp/target.h

@@ -89,6 +89,7 @@ class LIBSCRATCHCPP_EXPORT Target
         double volume() const;
         void setVolume(double newVolume);
 
+        virtual double soundEffect(Sound::Effect effect) const;
         virtual void setSoundEffect(Sound::Effect effect, double value);
 
         virtual Rect boundingRect() const;

src/scratch/target.cpp

@@ -422,6 +422,17 @@ void Target::setVolume(double newVolume)
     }
 }
 
+/*! Returns the value of the given sound effect. */
+double Target::soundEffect(Sound::Effect effect) const
+{
+    auto it = impl->soundEffects.find(effect);
+
+    if (it != impl->soundEffects.cend())
+        return it->second;
+
+    return 0;
+}
+
 /*! Sets the value of the given sound effect. */
 void Target::setSoundEffect(Sound::Effect effect, double value)
 {

test/mocks/targetmock.h

@@ -17,6 +17,7 @@ class TargetMock : public Target
 
         MOCK_METHOD(void, setLayerOrder, (int), (override));
 
+        MOCK_METHOD(double, soundEffect, (Sound::Effect), (const, override));
         MOCK_METHOD(void, setSoundEffect, (Sound::Effect, double), (override));
 
         MOCK_METHOD(Rect, boundingRect, (), (const, override));

test/scratch_classes/target_test.cpp

@@ -512,9 +512,11 @@ TEST(TargetTest, Volume)
     SoundPrivate::audioOutput = nullptr;
 }
 
-TEST(TargetTest, SetSoundEffect)
+TEST(TargetTest, SoundEffect)
 {
     Target target;
+    ASSERT_EQ(target.soundEffect(Sound::Effect::Pitch), 0);
+    ASSERT_EQ(target.soundEffect(Sound::Effect::Pan), 0);
 
     auto s1 = std::make_shared<SoundMock>();
     auto s2 = std::make_shared<SoundMock>();
@@ -531,11 +533,15 @@ TEST(TargetTest, SetSoundEffect)
     EXPECT_CALL(*s2, setEffect(Sound::Effect::Pitch, 12.5));
     EXPECT_CALL(*s3, setEffect(Sound::Effect::Pitch, 12.5));
     target.setSoundEffect(Sound::Effect::Pitch, 12.5);
+    ASSERT_EQ(target.soundEffect(Sound::Effect::Pitch), 12.5);
+    ASSERT_EQ(target.soundEffect(Sound::Effect::Pan), 0);
 
     EXPECT_CALL(*s1, setEffect(Sound::Effect::Pan, -56.7));
     EXPECT_CALL(*s2, setEffect(Sound::Effect::Pan, -56.7));
     EXPECT_CALL(*s3, setEffect(Sound::Effect::Pan, -56.7));
     target.setSoundEffect(Sound::Effect::Pan, -56.7);
+    ASSERT_EQ(target.soundEffect(Sound::Effect::Pitch), 12.5);
+    ASSERT_EQ(target.soundEffect(Sound::Effect::Pan), -56.7);
 
     auto s4 = std::make_shared<SoundMock>();
     EXPECT_CALL(*s4, setVolume);