Fix conversion of empty and whitespace string to double

Author: adazem009

src/scratch/value_functions_p.h

@@ -232,12 +232,8 @@ extern "C"
         if (ok)
             *ok = false;
 
-        if (!s || *s == '\0') {
-            if (ok)
-                *ok = true;
-
+        if (!s || *s == '\0')
             return 0;
-        }
 
         const size_t len = strlen(s);
         const char *begin = s;
@@ -251,11 +247,8 @@ extern "C"
         while (end > begin && IS_SPACE(*(end - 1)))
             --end;
 
-        if (begin == end) { // All spaces case
-            if (ok)
-                *ok = true;
-            return 0.0;
-        }
+        if (begin == end) // All spaces case
+            return 0;
 
         // Try to convert integer early
         bool isInt = false;

test/scratch_classes/value_test.cpp

@@ -285,7 +285,7 @@ TEST(ValueTest, StdStringConstructor)
         ASSERT_FALSE(v.isNaN());
         ASSERT_FALSE(v.isNumber());
         ASSERT_TRUE(v.isValidNumber());
-        ASSERT_TRUE(v.isInt());
+        ASSERT_FALSE(v.isInt());
         ASSERT_FALSE(v.isBool());
         ASSERT_TRUE(v.isString());
     }
@@ -299,8 +299,8 @@ TEST(ValueTest, StdStringConstructor)
         ASSERT_FALSE(v.isNegativeInfinity());
         ASSERT_FALSE(v.isNaN());
         ASSERT_FALSE(v.isNumber());
-        ASSERT_TRUE(v.isValidNumber());
-        ASSERT_TRUE(v.isInt());
+        ASSERT_FALSE(v.isValidNumber());
+        ASSERT_FALSE(v.isInt());
         ASSERT_FALSE(v.isBool());
         ASSERT_TRUE(v.isString());
     }
@@ -2536,6 +2536,31 @@ TEST(ValueTest, EqualityOperators)
         ASSERT_TRUE(v3 != v4);
     }
 
+    {
+        Value v1 = " ";
+        Value v2 = "";
+        Value v3 = "0";
+        Value v4 = 0;
+
+        ASSERT_FALSE(v1 == v2);
+        ASSERT_TRUE(v1 != v2);
+
+        ASSERT_FALSE(v1 == v3);
+        ASSERT_TRUE(v1 != v3);
+
+        ASSERT_FALSE(v1 == v4);
+        ASSERT_TRUE(v1 != v4);
+
+        ASSERT_FALSE(v2 == v3);
+        ASSERT_TRUE(v2 != v3);
+
+        ASSERT_FALSE(v2 == v4);
+        ASSERT_TRUE(v2 != v4);
+
+        ASSERT_TRUE(v3 == v4);
+        ASSERT_FALSE(v3 != v4);
+    }
+
     {
         Value v1(SpecialValue::Infinity);
         Value v2(SpecialValue::Infinity);