IDE Statistics (#697)

* Add some statistics to the edge functions in IDE

* Make more of AnalysisController internal and reduce dependencies

* More stats (WIP)

* EF Stats object

* More EF stats + add some JF stats

* Apply some review comments

* More review fixes

---------

Co-authored-by: Martin Mory <mmo@mail.upb.de>

Author: fabianbs96

include/phasar/Controller/AnalysisController.h

@@ -13,159 +13,27 @@
 #include "phasar/AnalysisStrategy/Strategies.h"
 #include "phasar/Controller/AnalysisControllerEmitterOptions.h"
 #include "phasar/DataFlow/IfdsIde/IFDSIDESolverConfig.h"
-#include "phasar/DataFlow/IfdsIde/Solver/IDESolver.h"
-#include "phasar/DataFlow/IfdsIde/Solver/IFDSSolver.h"
-#include "phasar/DataFlow/IfdsIde/SolverResults.h"
-#include "phasar/DataFlow/Mono/Solver/InterMonoSolver.h"
-#include "phasar/DataFlow/Mono/Solver/IntraMonoSolver.h"
-#include "phasar/PhasarLLVM/ControlFlow/LLVMBasedICFG.h"
-#include "phasar/PhasarLLVM/DB/LLVMProjectIRDB.h"
 #include "phasar/PhasarLLVM/HelperAnalyses.h"
-#include "phasar/PhasarLLVM/Pointer/LLVMAliasSet.h"
-#include "phasar/PhasarLLVM/SimpleAnalysisConstructor.h"
-#include "phasar/PhasarLLVM/TaintConfig/LLVMTaintConfig.h"
-#include "phasar/PhasarLLVM/TypeHierarchy/LLVMTypeHierarchy.h"
 #include "phasar/PhasarLLVM/Utils/DataFlowAnalysisType.h"
-#include "phasar/Utils/EnumFlags.h"
-#include "phasar/Utils/IO.h"
-#include "phasar/Utils/Soundness.h"
-
-#include <set>
-#include <string>
-#include <vector>
 
+#include <filesystem>
 namespace psr {
 
 class AnalysisController {
-private:
-  HelperAnalyses &HA;
-  std::vector<DataFlowAnalysisType> DataFlowAnalyses;
-  std::vector<std::string> AnalysisConfigs;
-  std::vector<std::string> EntryPoints;
-  [[maybe_unused]] AnalysisStrategy Strategy;
-  AnalysisControllerEmitterOptions EmitterOptions =
-      AnalysisControllerEmitterOptions::None;
-  std::string ProjectID;
-  std::filesystem::path ResultDirectory;
-  IFDSIDESolverConfig SolverConfig;
-
-  ///
-  /// \brief The maximum length of the CallStrings used in the InterMonoSolver
-  ///
-  static const unsigned K = 3;
-
-  void executeDemandDriven();
-
-  void executeIncremental();
-
-  void executeModuleWise();
-
-  void executeVariational();
-
-  void executeWholeProgram();
-
-  void emitRequestedHelperAnalysisResults();
-
-  void executeIFDSUninitVar();
-  void executeIFDSConst();
-  void executeIFDSTaint();
-  void executeIFDSType();
-  void executeIFDSSolverTest();
-  void executeIFDSFieldSensTaint();
-  void executeIDEXTaint();
-  void executeIDEOpenSSLTS();
-  void executeIDECSTDIOTS();
-  void executeIDELinearConst();
-  void executeIDESolverTest();
-  void executeIDEIIA();
-  void executeIntraMonoFullConstant();
-  void executeIntraMonoSolverTest();
-  void executeInterMonoSolverTest();
-  void executeInterMonoTaint();
-
-  template <typename SolverTy, typename ProblemTy, typename... ArgTys>
-  void executeMonoAnalysis(ArgTys &&...Args) {
-    auto Problem =
-        createAnalysisProblem<ProblemTy>(HA, std::forward<ArgTys>(Args)...);
-    SolverTy Solver(Problem);
-    Solver.solve();
-    emitRequestedDataFlowResults(Solver);
-  }
-
-  template <typename ProblemTy, typename... ArgTys>
-  void executeIntraMonoAnalysis(ArgTys &&...Args) {
-    executeMonoAnalysis<IntraMonoSolver_P<ProblemTy>, ProblemTy>(
-        std::forward<ArgTys>(Args)...);
-  }
-
-  template <typename ProblemTy, typename... ArgTys>
-  void executeInterMonoAnalysis(ArgTys &&...Args) {
-    executeMonoAnalysis<InterMonoSolver_P<ProblemTy, 3>, ProblemTy>(
-        std::forward<ArgTys>(Args)...);
-  }
-
-  template <typename SolverTy, typename ProblemTy, typename... ArgTys>
-  void executeIfdsIdeAnalysis(ArgTys &&...Args) {
-    auto Problem =
-        createAnalysisProblem<ProblemTy>(HA, std::forward<ArgTys>(Args)...);
-    SolverTy Solver(Problem, &HA.getICFG());
-    Solver.solve();
-    emitRequestedDataFlowResults(Solver);
-  }
-
-  template <typename ProblemTy, typename... ArgTys>
-  void executeIFDSAnalysis(ArgTys &&...Args) {
-    executeIfdsIdeAnalysis<IFDSSolver_P<ProblemTy>, ProblemTy>(
-        std::forward<ArgTys>(Args)...);
-  }
-
-  template <typename ProblemTy, typename... ArgTys>
-  void executeIDEAnalysis(ArgTys &&...Args) {
-    executeIfdsIdeAnalysis<IDESolver_P<ProblemTy>, ProblemTy>(
-        std::forward<ArgTys>(Args)...);
-  }
-
-  LLVMTaintConfig makeTaintConfig();
-
-  template <typename T> void emitRequestedDataFlowResults(T &Solver) {
-    if (EmitterOptions & AnalysisControllerEmitterOptions::EmitTextReport) {
-      if (!ResultDirectory.empty()) {
-        if (auto OFS =
-                openFileStream(ResultDirectory.string() + "/psr-report.txt")) {
-          Solver.emitTextReport(*OFS);
-        }
-      } else {
-        Solver.emitTextReport(llvm::outs());
-      }
-    }
-    if (EmitterOptions &
-        AnalysisControllerEmitterOptions::EmitGraphicalReport) {
-      if (!ResultDirectory.empty()) {
-        if (auto OFS =
-                openFileStream(ResultDirectory.string() + "/psr-report.html")) {
-          Solver.emitGraphicalReport(*OFS);
-        }
-      } else {
-        Solver.emitGraphicalReport(llvm::outs());
-      }
-    }
-    if (EmitterOptions & AnalysisControllerEmitterOptions::EmitRawResults) {
-      if (!ResultDirectory.empty()) {
-        if (auto OFS = openFileStream(ResultDirectory.string() +
-                                      "/psr-raw-results.txt")) {
-          Solver.dumpResults(*OFS);
-        }
-      } else {
-        Solver.dumpResults(llvm::outs());
-      }
-    }
-    if (EmitterOptions & AnalysisControllerEmitterOptions::EmitESGAsDot) {
-      llvm::outs()
-          << "Front-end support for 'EmitESGAsDot' to be implemented\n";
-    }
-  }
-
 public:
+  struct ControllerData {
+    HelperAnalyses *HA{};
+    std::vector<DataFlowAnalysisType> DataFlowAnalyses;
+    std::vector<std::string> AnalysisConfigs;
+    std::vector<std::string> EntryPoints;
+    [[maybe_unused]] AnalysisStrategy Strategy;
+    AnalysisControllerEmitterOptions EmitterOptions =
+        AnalysisControllerEmitterOptions::None;
+    std::string ProjectID;
+    std::filesystem::path ResultDirectory;
+    IFDSIDESolverConfig SolverConfig{};
+  };
+
   explicit AnalysisController(
       HelperAnalyses &HA, std::vector<DataFlowAnalysisType> DataFlowAnalyses,
       std::vector<std::string> AnalysisConfigs,
@@ -175,21 +43,15 @@ class AnalysisController {
       std::string ProjectID = "default-phasar-project",
       std::string OutDirectory = "");
 
-  ~AnalysisController() = default;
-
-  AnalysisController(const AnalysisController &) = delete;
-  AnalysisController(AnalysisController &&) = delete;
-  AnalysisController &operator=(const AnalysisController &) = delete;
-  AnalysisController &operator=(const AnalysisController &&) = delete;
-
-  void executeAs(AnalysisStrategy Strategy);
-
   static constexpr bool
   needsToEmitPTA(AnalysisControllerEmitterOptions EmitterOptions) {
     return (EmitterOptions & AnalysisControllerEmitterOptions::EmitPTAAsDot) ||
            (EmitterOptions & AnalysisControllerEmitterOptions::EmitPTAAsJson) ||
            (EmitterOptions & AnalysisControllerEmitterOptions::EmitPTAAsText);
   }
+
+private:
+  ControllerData Data;
 };
 
 } // namespace psr