Skip to content

Commit 1e46bfe

Browse files
committed
Improve cpflow workflow review feedback
1 parent b9095c6 commit 1e46bfe

2 files changed

Lines changed: 9 additions & 1 deletion

File tree

.github/workflows/cpflow-deploy-review-app.yml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,8 @@ jobs:
129129
- name: Validate review app deployment source
130130
if: steps.config.outputs.ready == 'true'
131131
id: source
132+
env:
133+
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
132134
shell: bash
133135
run: |
134136
set -euo pipefail
@@ -147,7 +149,12 @@ jobs:
147149
exit 0
148150
fi
149151
150-
echo "Review app deploys from fork pull requests are not allowed because this workflow uses repository secrets." >&2
152+
message="Review app deploys from fork pull requests are not allowed because this workflow uses repository secrets."
153+
if ! gh pr comment "${PR_NUMBER}" --body "${message}"; then
154+
echo "Failed to post fork rejection comment to PR #${PR_NUMBER}" >&2
155+
fi
156+
157+
echo "${message}" >&2
151158
exit 1
152159
153160
- name: Checkout PR commit

.github/workflows/cpflow-promote-staging-to-production.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -275,6 +275,7 @@ jobs:
275275
run: |
276276
# Best-effort rollback: try every workload, aggregate failures, exit non-zero at the end
277277
# if any failed. A single cpln hiccup shouldn't leave other workloads mid-promotion.
278+
# `set -e` is intentionally omitted so one failed workload update does not skip the rest.
278279
set -uo pipefail
279280
280281
rollback_failures=0

0 commit comments

Comments
 (0)