Update rubocop and rubocop-performance (#72)

* Change `rubocop` version specification to `~> 1.8.1`
* Change `rubocop-performance` version specification to `~> 1.7.0`
* Update `.rubocop.yml` to match current shipcloud style guides
* Correct styling issues automatically with `rubocop -a`
* Fix remaining styling issues, mostly by adding magic comment
`# frozen_string_literal: true` to files

[ch7626](https://app.clubhouse.io/shipcloud/story/7626)

Author: Dorothee Laugwitz

.rubocop.yml

@@ -3,11 +3,14 @@
 - Add attr_accessor for `service` to class `Shipcloud::Shipment` to be able to access the service attribute at the shipment object.
 - Add attr_accessor for `additional_services` to class `Shipcloud::Shipment` to be able to access the additional_services attribute at the shipment object.
 - Add attr_reader for `label_voucher_url` to class `Shipcloud::Shipment` to be able to read the label_voucher_url (QR Code url) attribute at the shipment object.
+- Added missing `frozen_string_literal: true` magic comments to files
 
 ### Changed
 - Set required ruby version to >= 2.6
 - Replace Travis CI with CircleCI
 - Specify simplecov to be ~> 0.21.0
+- Specify `rubocop` to be `~> 1.10.0`
+- Specify `rubocop-performance` to be `~> 1.7.0`
 
 ### Deprecated
 
@@ -16,6 +19,7 @@
 - Drop support for RBX
 
 ### Fixed
+- Fix rubocop styling issues
 
 ### Security
 
@@ -24,16 +28,6 @@
 - Support shipments with pickup requests as required for [TNT](https://developers.shipcloud.io/carriers/tnt.html).
 - Add attr_accessor for `email` to class `Shipcloud::Address` to be able to access the email attribute at the address object.
 
-### Changed
-
-### Deprecated
-
-### Removed
-
-### Fixed
-
-### Security
-
 ## [0.10.0] - 2019-08-07
 ### Added
 - Add the possibility to specify custom affiliate_id on every request

CHANGELOG.md

@@ -1,4 +1,5 @@
-source 'https://rubygems.org'
+# frozen_string_literal: true
+source "https://rubygems.org"
 
 # Specify your gem's dependencies in shipcloud.gemspec
 gemspec

Gemfile

@@ -1,12 +1,13 @@
+# frozen_string_literal: true
 require "bundler/gem_tasks"
-require 'rspec/core/rake_task'
+require "rspec/core/rake_task"
 
 RSpec::Core::RakeTask.new(:spec)
 
 task :console do
-  require 'irb'
-  require 'irb/completion'
-  require 'shipcloud'
+  require "irb"
+  require "irb/completion"
+  require "shipcloud"
   ARGV.clear
   IRB.start
 end

Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Shipcloud
   class Address < Base
     include Shipcloud::Operations::Update

lib/shipcloud/address.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Shipcloud
   class Base
     include Shipcloud::Operations::Create
@@ -28,17 +30,15 @@ def self.camel_to_snakecase(string)
     end
 
     def self.class_name
-      self.name.split("::").last
+      name.split("::").last
     end
 
     def self.base_url
       "#{class_name.downcase}s"
     end
 
-    def self.create_response_root
-    end
+    def self.create_response_root; end
 
-    def self.index_response_root
-    end
+    def self.index_response_root; end
   end
 end

lib/shipcloud/base.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Shipcloud
   class Carrier < Base
     include Shipcloud::Operations::All

lib/shipcloud/carrier.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Shipcloud
   module Operations
     module All

lib/shipcloud/operations/all.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Shipcloud
   module Operations
     module Create
@@ -18,7 +20,7 @@ def create(attributes, api_key: nil, affiliate_id: nil)
           if create_response_root
             response = response.fetch(create_response_root, {})
           end
-          self.new(response)
+          new(response)
         end
       end
 

lib/shipcloud/operations/create.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Shipcloud
   module Operations
     module Delete