Skip to content

Commit 9234ab4

Browse files
committed
MAG-578: Fix to improve fulfillment compatibility
Event moved from adminhtml to global, so now observer also listen to other areas like API requests Cast tracking numbers to strings to correct in memory values like XML nodes (e.g.: when using ShipStation extension)
1 parent 919c1f8 commit 9234ab4

2 files changed

Lines changed: 12 additions & 11 deletions

File tree

www/magento/app/code/community/Signifyd/Connect/Helper/Data.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1374,10 +1374,10 @@ public function getTrackingNumbers(Mage_Sales_Model_Order_Shipment $shipment)
13741374

13751375
/** @var Mage_Sales_Model_Order_Shipment_Track $tracking */
13761376
foreach ($trackingCollection->getItems() as $tracking) {
1377-
$number = trim($tracking->getNumber());
1377+
$number = trim((string) $tracking->getNumber());
13781378

13791379
if (empty($number) == false) {
1380-
$trackingNumbers[] = $tracking->getNumber();
1380+
$trackingNumbers[] = $number;
13811381
}
13821382
}
13831383

www/magento/app/code/community/Signifyd/Connect/etc/config.xml

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -186,6 +186,16 @@
186186
</signifyd_connect>
187187
</observers>
188188
</order_cancel_after>
189+
190+
<!-- Fulfilment events -->
191+
<sales_order_shipment_track_save_commit_after>
192+
<observers>
193+
<signifyd_connect>
194+
<model>signifyd_connect/observer</model>
195+
<method>salesOrderShipmentTrackSaveCommitAfter</method>
196+
</signifyd_connect>
197+
</observers>
198+
</sales_order_shipment_track_save_commit_after>
189199
</events>
190200
</global>
191201
<crontab>
@@ -294,15 +304,6 @@
294304
</signifyd_connect>
295305
</observers>
296306
</core_block_abstract_to_html_before>
297-
<!-- Fulfilment events -->
298-
<sales_order_shipment_track_save_commit_after>
299-
<observers>
300-
<signifyd_connect>
301-
<model>signifyd_connect/observer</model>
302-
<method>salesOrderShipmentTrackSaveCommitAfter</method>
303-
</signifyd_connect>
304-
</observers>
305-
</sales_order_shipment_track_save_commit_after>
306307
</events>
307308
</adminhtml>
308309
<default>

0 commit comments

Comments
 (0)