Update monkeyruleset

Author: silverhack

core/modules/monkeyruleset/private/Get-AvailableRule.ps1

@@ -68,19 +68,36 @@ Function Get-AvailableRule{
                 }
                 #Select path
                 $_path = $rule.rule | Select-Object -ExpandProperty path | Select-Object -Unique
-                $exists = $Script:Dataset | Select-Object -ExpandProperty $_path -ErrorAction Ignore
-                If($exists){
-                    $ruleObj.path = $_path;
-                    $ruleObj.skipped = $false;
-                    $ruleObj.reason = "Data exists in dataset";
+                If($null -eq $_path){
+                    #removing rule
+                    Write-Verbose -Message ($Script:messages.UnitItemNotFound -f $rule.displayName)
+                    $ruleObj.path = $null;
+                    $ruleObj.skipped = $true;
+                    $ruleObj.reason = "Data is not present in dataset";
+                    
                 }
-                Else{
+                ElseIf($_path.Length -eq 0){
                     #removing rule
                     Write-Verbose -Message ($Script:messages.UnitItemNotFound -f $rule.displayName)
-                    $ruleObj.path = $_path;
+                    $ruleObj.path = $null;
                     $ruleObj.skipped = $true;
                     $ruleObj.reason = "Data is not present in dataset";
                 }
+                Else{
+                    $exists = $Script:Dataset | Select-Object -ExpandProperty $_path -ErrorAction Ignore
+                    If($exists){
+                        $ruleObj.path = $_path;
+                        $ruleObj.skipped = $false;
+                        $ruleObj.reason = "Data exists in dataset";
+                    }
+                    Else{
+                        #removing rule
+                        Write-Verbose -Message ($Script:messages.UnitItemNotFound -f $rule.displayName)
+                        $ruleObj.path = $_path;
+                        $ruleObj.skipped = $true;
+                        $ruleObj.reason = "Data is not present in dataset";
+                    }
+                }
                 #Add to array
                 $formattedRules.Add($ruleObj)
             }

core/modules/monkeyruleset/private/Get-NewFilter2.ps1

@@ -117,6 +117,12 @@ Function Get-ObjectFromDataset{
                             Write-Warning -Message ($Script:messages.PathNotFoundErrorMessage -f $InputObject.rule.path.Trim().ToString())
                         }
                     }
+                    ElseIf($InputObject -is [System.String]){
+                        $_objects = Get-ObjectPropertyByPath -InputObject $Script:Dataset -Property $InputObject
+                        If($null -ne $_objects){
+                            $_objects | Select-Object -ExpandProperty Data -ErrorAction Ignore
+                        }
+                    }
                 }
             }
             Else{

core/modules/monkeyruleset/private/Get-ObjectFromDataset.ps1

@@ -66,6 +66,9 @@ Function New-MonkeyFindingObject {
             If($null -eq $Metadata){
                 $Metadata = New-EmptyMetadataObject
             }
+            #Normalize IdSuffix
+            $InputObject.idSuffix = $InputObject.idSuffix.Replace('.','_').Replace(' ','_').ToLower();
+            #Add properties
             $InputObject | Add-Member -Type NoteProperty -name metadata -value $Metadata -Force
             $InputObject | Add-Member -Type NoteProperty -name affectedResources -value $AffectedObjects -Force
             $InputObject | Add-Member -Type NoteProperty -name resources -value $Resources -Force
@@ -170,7 +173,7 @@ Function New-MonkeyFindingObject {
             $InputObject | Add-Member -Type ScriptMethod -Name getNewIdSuffix -Value {
                 If($null -ne $this.idSuffix.Replace(' ','_')){
                     $guid = [System.Guid]::NewGuid().ToString('N')
-                    return ("{0}_{1}" -f $this.idSuffix, $guid)
+                    return ("{0}_{1}" -f $this.idSuffix, $guid).ToLower()
                 }
             } -Force
             return $InputObject

core/modules/monkeyruleset/private/Get-StatusCode.ps1

@@ -68,6 +68,7 @@ Function Resolve-Include{
                 Catch{
                     Write-Warning $_.Exception.Message
                     Write-Verbose $_.Exception
+                    Write-Warning -Message ($Script:messages.FileNotFoundGenericMessage -f $includeFile)
                 }
             }
             Else{