Skip to content

Commit 18352d9

Browse files
waleedlatif1claude
andcommitted
fix(audit): align metadata with established recordAudit patterns
- Add actorName/actorEmail to all new credential and schedule audit calls to match the established pattern (e.g., api-keys, byok-keys, knowledge) - Add resourceId and resourceName to forget-password audit call - Enhance forget-password description with user email Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent a325138 commit 18352d9

5 files changed

Lines changed: 23 additions & 1 deletion

File tree

apps/sim/app/api/auth/forget-password/route.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,9 @@ export async function POST(request: NextRequest) {
6868
actorEmail: existingUser.email,
6969
action: AuditAction.PASSWORD_RESET_REQUESTED,
7070
resourceType: AuditResourceType.PASSWORD,
71-
description: 'Password reset requested',
71+
resourceId: existingUser.id,
72+
resourceName: existingUser.email ?? undefined,
73+
description: `Password reset requested for ${existingUser.email}`,
7274
request,
7375
})
7476
}

apps/sim/app/api/credentials/[id]/route.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -170,6 +170,8 @@ export async function PUT(request: NextRequest, { params }: { params: Promise<{
170170
recordAudit({
171171
workspaceId: access.credential.workspaceId,
172172
actorId: session.user.id,
173+
actorName: session.user.name,
174+
actorEmail: session.user.email,
173175
action: AuditAction.CREDENTIAL_UPDATED,
174176
resourceType: AuditResourceType.CREDENTIAL,
175177
resourceId: id,
@@ -268,6 +270,8 @@ export async function DELETE(
268270
recordAudit({
269271
workspaceId: access.credential.workspaceId,
270272
actorId: session.user.id,
273+
actorName: session.user.name,
274+
actorEmail: session.user.email,
271275
action: AuditAction.CREDENTIAL_DELETED,
272276
resourceType: AuditResourceType.CREDENTIAL,
273277
resourceId: id,
@@ -333,6 +337,8 @@ export async function DELETE(
333337
recordAudit({
334338
workspaceId: access.credential.workspaceId,
335339
actorId: session.user.id,
340+
actorName: session.user.name,
341+
actorEmail: session.user.email,
336342
action: AuditAction.CREDENTIAL_DELETED,
337343
resourceType: AuditResourceType.CREDENTIAL,
338344
resourceId: id,
@@ -361,6 +367,8 @@ export async function DELETE(
361367
recordAudit({
362368
workspaceId: access.credential.workspaceId,
363369
actorId: session.user.id,
370+
actorName: session.user.name,
371+
actorEmail: session.user.email,
364372
action: AuditAction.CREDENTIAL_DELETED,
365373
resourceType: AuditResourceType.CREDENTIAL,
366374
resourceId: id,

apps/sim/app/api/credentials/route.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -616,6 +616,8 @@ export async function POST(request: NextRequest) {
616616
recordAudit({
617617
workspaceId,
618618
actorId: session.user.id,
619+
actorName: session.user.name,
620+
actorEmail: session.user.email,
619621
action: AuditAction.CREDENTIAL_CREATED,
620622
resourceType: AuditResourceType.CREDENTIAL,
621623
resourceId: credentialId,

apps/sim/app/api/schedules/[id]/route.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,8 @@ export async function PUT(request: NextRequest, { params }: { params: Promise<{
146146
recordAudit({
147147
workspaceId,
148148
actorId: session.user.id,
149+
actorName: session.user.name,
150+
actorEmail: session.user.email,
149151
action: AuditAction.SCHEDULE_UPDATED,
150152
resourceType: AuditResourceType.SCHEDULE,
151153
resourceId: scheduleId,
@@ -209,6 +211,8 @@ export async function PUT(request: NextRequest, { params }: { params: Promise<{
209211
recordAudit({
210212
workspaceId,
211213
actorId: session.user.id,
214+
actorName: session.user.name,
215+
actorEmail: session.user.email,
212216
action: AuditAction.SCHEDULE_UPDATED,
213217
resourceType: AuditResourceType.SCHEDULE,
214218
resourceId: scheduleId,
@@ -253,6 +257,8 @@ export async function PUT(request: NextRequest, { params }: { params: Promise<{
253257
recordAudit({
254258
workspaceId,
255259
actorId: session.user.id,
260+
actorName: session.user.name,
261+
actorEmail: session.user.email,
256262
action: AuditAction.SCHEDULE_UPDATED,
257263
resourceType: AuditResourceType.SCHEDULE,
258264
resourceId: scheduleId,
@@ -300,6 +306,8 @@ export async function DELETE(
300306
recordAudit({
301307
workspaceId,
302308
actorId: session.user.id,
309+
actorName: session.user.name,
310+
actorEmail: session.user.email,
303311
action: AuditAction.SCHEDULE_DELETED,
304312
resourceType: AuditResourceType.SCHEDULE,
305313
resourceId: scheduleId,

apps/sim/app/api/schedules/route.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -283,6 +283,8 @@ export async function POST(req: NextRequest) {
283283
recordAudit({
284284
workspaceId,
285285
actorId: session.user.id,
286+
actorName: session.user.name,
287+
actorEmail: session.user.email,
286288
action: AuditAction.SCHEDULE_CREATED,
287289
resourceType: AuditResourceType.SCHEDULE,
288290
resourceId: id,

0 commit comments

Comments
 (0)