Incorrectly formatted JSON in challenge response (#99)

sirdan69 · seratch · web-flow · commit b48128008040 · 2021-12-09T12:21:19.000+09:00
Co-authored-by: Kazuhiro Sera &lt;seratch@gmail.com&gt;
diff --git a/slackeventsapi/server.py b/slackeventsapi/server.py
@@ -108,7 +108,8 @@ def event():
             # Echo the URL verification challenge code back to Slack
             if "challenge" in event_data:
                 return make_response(
-                    event_data.get("challenge"), 200, {"content_type": "application/json"}
+                    {"challenge": event_data.get("challenge")}, 200,
+                    {"content_type": "application/json"}
                 )
 
             # Parse the Event payload and emit the event to the event listener
diff --git a/tests/test_server.py b/tests/test_server.py
@@ -53,7 +53,7 @@ def test_url_challenge(client):
         }
     )
     assert res.status_code == 200
-    assert bytes.decode(res.data) == "valid_challenge_token"
+    assert res.json.get("challenge") == "valid_challenge_token"
 
 
 def test_no_request_timestamp_header(client):

Original file line number	Diff line number	Diff line change
`@@ -108,7 +108,8 @@ def event():`
`108`	`108`	`# Echo the URL verification challenge code back to Slack`
`109`	`109`	`if "challenge" in event_data:`
`110`	`110`	`return make_response(`
`111`		`- event_data.get("challenge"), 200, {"content_type": "application/json"}`
	`111`	`+ {"challenge": event_data.get("challenge")}, 200,`
	`112`	`+ {"content_type": "application/json"}`
`112`	`113`	`)`
`113`	`114`
`114`	`115`	`# Parse the Event payload and emit the event to the event listener`
Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ def test_url_challenge(client):`
`53`	`53`	`}`
`54`	`54`	`)`
`55`	`55`	`assert res.status_code == 200`
`56`		`- assert bytes.decode(res.data) == "valid_challenge_token"`
	`56`	`+ assert res.json.get("challenge") == "valid_challenge_token"`
`57`	`57`
`58`	`58`
`59`	`59`	`def test_no_request_timestamp_header(client):`