Aligned the messages for failures and composition failures: value is provided as repr already so no need to put it between <>

Author: Sylvain MARIE

valid8/composition.py

@@ -91,7 +91,7 @@ def get_details(self, compact_mode=False):
 
         # Note: we do note cite the value in the message since it is most probably available in inner messages [{val}]
         what = self.get_what()
-        possibly_value = "" if compact_mode else (" for value <%s>" % repr(self.wrong_value))
+        possibly_value = "" if compact_mode else (" for value %s" % repr(self.wrong_value))
         return '%s%s. Successes: %s / Failures: %s.' % (what, possibly_value, self.successes, failures_str)
 
     def play_all_validators(self, validators, value, **ctx):

valid8/tests/readme/test_readme_index.py

@@ -185,7 +185,7 @@ def build_house(name, surface=None):
     e = exc_info.value
     assert str(e) == "name should be a non-empty string. " \
                      "Error validating input [name=''] for function [build_house]. " \
-                     "At least one validation function failed for value <''>. " \
+                     "At least one validation function failed for value ''. " \
                      "Successes: [\"instance_of_%s\"] / Failures: {'len(s) > 0': 'Returned False.'}." \
                      "" % (repr(str), )
 
@@ -353,7 +353,7 @@ def test_readme_index_usage_composition():
         assert_valid('surface', surf, (x >= 0) & (x < 10000), is_multiple_of(100))
     e = exc_info.value
     assert str(e) == "Error validating [surface=-1]. " \
-                     "At least one validation function failed for value <-1>. " \
+                     "At least one validation function failed for value -1. " \
                      "Successes: [] / Failures: {'(x >= 0) & (x < 10000)': 'Returned False.', " \
                      "'is_multiple_of_100': 'IsNotMultipleOf: Value should be a multiple of 100.'}."
 
@@ -368,7 +368,7 @@ class InvalidSurface(ValidationError):
     e = exc_info.value
     assert str(e) == "Surface should be between 0 and 10000 and be a multiple of 100, found -1. " \
                      "Error validating [surface=-1]. " \
-                     "At least one validation function failed for value <-1>. " \
+                     "At least one validation function failed for value -1. " \
                      "Successes: [] / Failures: {" \
                      "'(x >= 0) & (x < 10000)': 'Returned False.', " \
                      "'is_multiple_of_100': 'IsNotMultipleOf: Value should be a multiple of 100.'}."
@@ -380,7 +380,7 @@ class InvalidSurface(ValidationError):
                      (is_multiple_of(100), 'Surface should be a multiple of 100'))
     e = exc_info.value
     assert str(e) == "Error validating [surface=-1]. " \
-                     "At least one validation function failed for value <-1>. " \
+                     "At least one validation function failed for value -1. " \
                      "Successes: [] / Failures: {" \
                      "'(x >= 0) & (x < 10000)': 'InvalidValue: Surface should be between 0 and 10000. " \
                      "Returned False.', " \
@@ -400,7 +400,7 @@ class InvalidSurface(ValidationError):
     e = exc_info.value
     assert str(e) == "Surface should be between 0 and 10000 and be a multiple of 100, found -1. " \
                      "Error validating [surface=-1]. " \
-                     "At least one validation function failed for value <-1>. " \
+                     "At least one validation function failed for value -1. " \
                      "Successes: [] / Failures: {" \
                      "'(x >= 0) & (x < 10000)': 'InvalidValue: Surface should be between 0 and 10000. " \
                      "Returned False.', " \

valid8/tests/readme/test_readme_syntax.py

@@ -52,7 +52,7 @@ class NotFinite(ValidationFailure):
 
     assert str(exc_info.value) == "Error validating [x=-1]. " \
                                   "At least one validation function failed for value " \
-                                  "<-1>. Successes: ['isfinite'] / Failures: " \
+                                  "-1. Successes: ['isfinite'] / Failures: " \
                                   "{'is_even': 'IsNotEven: Value should be even.', " \
                                   "'i > 0': 'InvalidValue: x should be strictly positive. Returned False.'}."
 
@@ -80,6 +80,6 @@ class NotFinite(ValidationFailure):
     # NOTE:
     assert str(exc_info.value) == "Error validating [x=-1]. " \
                                   "At least one validation function failed for value " \
-                                  "<-1>. Successes: ['isfinite'] / Failures: " \
+                                  "-1. Successes: ['isfinite'] / Failures: " \
                                   "{'is_even': 'InvalidValue: x should be even. IsNotEven: Value should be even.', " \
                                   "'i > 0': 'InvalidValue: x should be strictly positive. Returned False.'}."

valid8/tests/readme/test_readme_usage.py

@@ -52,7 +52,7 @@ def hello(age):
         hello(152)
     e = exc_info.value
     assert str(e) == "Error validating [age=152]. " \
-                     "At least one validation function failed for value <152>. " \
+                     "At least one validation function failed for value 152. " \
                      "Successes: ['isfinite'] / Failures: {" \
                      "'between_0_and_150': 'NotInRange: 0 <= x <= 150 does not hold for x=152.'}."
 
@@ -67,7 +67,7 @@ def hello(age):
         hello(12.5)
     e = exc_info.value
     assert str(e) == "Error validating [age=12.5]. " \
-                     "At least one validation function failed for value <12.5>. " \
+                     "At least one validation function failed for value 12.5. " \
                      "Successes: ['isfinite', 'between_0_and_150'] / Failures: {'int(x) == x': 'Returned False.'}."
 
 

valid8/tests/test_entry_points_annotations.py

@@ -264,7 +264,7 @@ def myfunc(a, b):
         myfunc(4, 21)  # InputValidationError: a is not a multiple of 3
     e = exc_info.value
     assert str(e) == "Error validating input [a=4] for function [myfunc]. " \
-                     "At least one validation function failed for value <4>. " \
+                     "At least one validation function failed for value 4. " \
                      "Successes: ['gt_assert2'] / Failures: {'is_mod_3': 'Returned False.'}."
 
     with pytest.raises(InputValidationError) as exc_info:
@@ -277,7 +277,7 @@ def myfunc(a, b):
         myfunc(1, 0)  # InputValidationError caused by AssertionError: a is not >= 2
     e = exc_info.value
     assert str(e) == "Error validating input [a=1] for function [myfunc]. " \
-                     "At least one validation function failed for value <1>. " \
+                     "At least one validation function failed for value 1. " \
                      "Successes: [] / " \
                      "Failures: {'gt_assert2': 'AssertionError: assert 1 >= 2', 'is_mod_3': 'Returned False.'}."
 
@@ -309,7 +309,7 @@ def myfunc(a):
         myfunc(0)  # InputValidationError: a >= 1 does not hold
     e = exc_info.value
     assert str(e) == "Error validating input [a=0] for function [myfunc]. " \
-                     "At least one validation function failed for value <0>. " \
+                     "At least one validation function failed for value 0. " \
                      "Successes: ['lesser_than_12', 'is_mod'] / " \
                      "Failures: {'gt_ex1': 'ValidationFailure: x >= 1 does not hold for x=0.'}."
 
@@ -318,7 +318,7 @@ def myfunc(a):
         myfunc(3)  # InputValidationError: a % 5 == 0 does not hold
     e = exc_info.value
     assert str(e) == "Error validating input [a=3] for function [myfunc]. " \
-                     "At least one validation function failed for value <3>. " \
+                     "At least one validation function failed for value 3. " \
                      "Successes: ['gt_ex1', 'lesser_than_12'] / " \
                      "Failures: {'is_mod': 'ValidationFailure: x % 5 == 0 does not hold for x=3.'}."
 
@@ -327,7 +327,7 @@ def myfunc(a):
         myfunc(15)  # InputValidationError: a < 12 does not hold
     e = exc_info.value
     assert str(e) == "Error validating input [a=15] for function [myfunc]. " \
-                     "At least one validation function failed for value <15>. " \
+                     "At least one validation function failed for value 15. " \
                      "Successes: ['gt_ex1', 'is_mod'] / " \
                      "Failures: {'lesser_than_12': 'TooBig: x <= 12 does not hold for x=15.'}."