Fixed bug in is_in when the reference object was a non-set container. Fixed #47

Author: Sylvain MARIE

valid8/tests/validation_lib/test_validators_collections.py

@@ -13,6 +13,9 @@ def test_is_in():
     with pytest.raises(ValidationFailure):
         is_in({'+', '-'})('*')
 
+    # also test non-set iterable types
+    is_in(('+', '-'))('+')
+
 
 def test_contains():
     """ Checks that contains works """

valid8/validation_lib/collections.py

@@ -1,6 +1,6 @@
 try:  # python 3.5+
     # noinspection PyUnresolvedReferences
-    from typing import Set, Tuple
+    from typing import Set, Tuple, Container
 except ImportError:
     pass
 
@@ -158,7 +158,7 @@ def __init__(self, wrong_value, allowed_values, **kwargs):
                                                  **kwargs)
 
 
-def is_in(allowed_values  # type: Set
+def is_in(allowed_values  # type: Container
           ):
     """
     'Values in' validation_function generator.
@@ -174,7 +174,7 @@ def is_in_allowed_values(x):
             # raise ValidationFailure('is_in: x in ' + str(allowed_values) + ' does not hold for x=' + str(x))
             raise NotInAllowedValues(wrong_value=x, allowed_values=allowed_values)
 
-    is_in_allowed_values.__name__ = 'is_in_%s' % allowed_values
+    is_in_allowed_values.__name__ = 'is_in_%s' % (allowed_values, )
     return is_in_allowed_values