Merge pull request #16 from SaiSandeepKantareddy/main

Add macOS x86_64 wheel support and prevent broken sdist fallback

Author: sushanthpy

.github/workflows/release.yml

@@ -40,6 +40,7 @@
 # Platforms supported:
 #   - Linux x86_64 (manylinux_2_17)
 #   - macOS ARM64 (Apple Silicon)
+#   - macOS x86_64 (Intel)
 #   - Windows x64
 #
 # Python versions supported: 3.9, 3.10, 3.11, 3.12, 3.13
@@ -99,6 +100,11 @@ jobs:
             target: aarch64-apple-darwin
             wheel_platform: macosx_11_0_arm64
             archive_ext: tar.gz
+
+          - os: macos-13
+            target: x86_64-apple-darwin
+            wheel_platform: macosx_10_15_x86_64
+            archive_ext: tar.gz
 
           - os: windows-latest
             target: x86_64-pc-windows-msvc
@@ -403,6 +409,7 @@ jobs:
           
           - ✅ **Linux x86_64** (manylinux_2_17_x86_64)
           - ✅ **macOS ARM64** (Apple Silicon, macosx_11_0_arm64)
+          - ✅ **macOS x86_64** (Intel, macosx_10_15_x86_64)
           - ✅ **Windows x64** (win_amd64)
           
           ### Python Version Support
@@ -422,7 +429,7 @@ jobs:
           
           ### Source Distribution
           
-          The source distribution (`.tar.gz`) is also available for custom builds, though binaries are not included and would need to be obtained separately from the main SochDB repository.
+          The source distribution (`.tar.gz`) is attached to the GitHub release for maintainers and custom builds, but it is intentionally not uploaded to PyPI while unsupported platform combinations can still fall back to a broken binary mix.
           
           ---
           
@@ -475,12 +482,13 @@ jobs:
           path: dist/
           merge-multiple: true
 
-      - name: List packages
+      - name: Remove source distribution from PyPI payload
         run: |
-          echo "=== Packages to upload ==="
+          rm -f dist/*.tar.gz
+          echo "=== Wheels to upload to PyPI ==="
           ls -la dist/
           if [ -z "$(ls -A dist/)" ]; then
-            echo "ERROR: No Python packages found!"
+            echo "ERROR: No wheel packages found!"
             exit 1
           fi
 

README.md

@@ -248,7 +248,9 @@ services:
 
 **Operating Systems:**
 - ✅ Linux (Ubuntu 20.04+, RHEL 8+)
-- ✅ macOS (10.15+, both Intel and Apple Silicon)
+- ✅ macOS (10.15+, Apple Silicon arm64 packaged path)
+- ✅ macOS Intel (10.15+, x86_64 packaged wheel path)
+- ⚠️  Apple Silicon users should still prefer a native arm64 Python env over Rosetta
 - ⚠️  Windows (requires native builds)
 
 **File Descriptors:**
@@ -286,7 +288,7 @@ db = Database.open_concurrent("./data.db")
 OSError: libsochdb_storage.dylib not found
 ```
 
-**macOS**:
+**macOS (if you are not on the supported packaged arm64 path)**:
 ```bash
 # Build and install library
 cd /path/to/sochdb
@@ -460,7 +462,9 @@ pip install sochdb
 | Platform | Architecture | Status |
 |----------|--------------|--------|
 | Linux | x86_64, aarch64 | ✅ Full support |
-| macOS | x86_64, arm64 | ✅ Full support |
+| macOS | arm64 | ✅ Packaged wheel support |
+| macOS Intel | x86_64 | ✅ Packaged wheel support |
+| Apple Silicon via Rosetta | x86_64 | ⚠️ Prefer native arm64 Python first |
 | Windows | x86_64 | ✅ Full support |
 
 **Optional Dependencies:**

RELEASE.md

@@ -26,8 +26,11 @@ Each platform-specific wheel contains:
 The workflow builds wheels for:
 - **Linux x86_64** (`manylinux_2_17_x86_64`)
 - **macOS ARM64** (`macosx_11_0_arm64`) - Apple Silicon
+- **macOS x86_64** (`macosx_10_15_x86_64`) - Intel
 - **Windows x64** (`win_amd64`)
 
+Unsupported platforms should not fall back to a PyPI source distribution, because that can produce a misleading install with the wrong bundled native binaries.
+
 ### 4. Python Version Support
 Wheels are compatible with:
 - Python 3.9
@@ -43,6 +46,7 @@ Wheels are compatible with:
 2. The release must have platform-specific archives:
    - `sochdb-{version}-x86_64-unknown-linux-gnu.tar.gz`
    - `sochdb-{version}-aarch64-apple-darwin.tar.gz`
+   - `sochdb-{version}-x86_64-apple-darwin.tar.gz`
    - `sochdb-{version}-x86_64-pc-windows-msvc.zip`
 
 ### Running a Release
@@ -72,7 +76,8 @@ Wheels are compatible with:
    - Generates release notes with installation instructions
 
 4. **Publish to PyPI**:
-   - Uploads all wheels and source distribution
+   - Uploads wheels only
+   - Keeps the source distribution off PyPI so unsupported platforms do not fall back to a broken binary mix
    - Uses OIDC Trusted Publisher (no token needed)
 
 5. **Summary**:
@@ -155,7 +160,7 @@ sochdb-server --help
 - [ ] Review workflow artifacts and logs
 - [ ] Run workflow with `dry_run: false` for production
 - [ ] Verify GitHub release is created
-- [ ] Verify packages appear on PyPI
+- [ ] Verify only wheel packages appear on PyPI (no sdist upload)
 - [ ] Test installation: `pip install sochdb-client==X.Y.Z`
 - [ ] Update CHANGELOG.md with release notes