Merge pull request #671 from Brian-Flores/issue668

New Command: `ibmcloud sl account hook-delete`

Author: allmightyspiff

plugin/commands/account/account.go

@@ -29,6 +29,7 @@ func SetupCobraCommands(sl *metadata.SoftlayerCommand) *cobra.Command {
 	cobraCmd.AddCommand(NewSummaryCommand(sl).Command)
 	cobraCmd.AddCommand(NewHooksCommand(sl).Command)
 	cobraCmd.AddCommand(NewHookCreateCommand(sl).Command)
+	cobraCmd.AddCommand(NewHookDeleteCommand(sl).Command)
 	return cobraCmd
 }
 

plugin/commands/account/account_test.go

@@ -25,6 +25,7 @@ var availableCommands = []string{
 	"event-detail",
 	"events",
 	"hook-create",
+	"hook-delete",
 	"hooks",
 	"invoice-detail",
 	"invoices",

plugin/commands/account/hook_delete.go

@@ -0,0 +1,56 @@
+package account
+
+import (
+	"strconv"
+
+	"github.com/spf13/cobra"
+
+	"github.ibm.com/SoftLayer/softlayer-cli/plugin/errors"
+	. "github.ibm.com/SoftLayer/softlayer-cli/plugin/i18n"
+	"github.ibm.com/SoftLayer/softlayer-cli/plugin/managers"
+	"github.ibm.com/SoftLayer/softlayer-cli/plugin/metadata"
+)
+
+type HookDeleteCommand struct {
+	*metadata.SoftlayerCommand
+	AccountManager managers.AccountManager
+	Command        *cobra.Command
+}
+
+func NewHookDeleteCommand(sl *metadata.SoftlayerCommand) *HookDeleteCommand {
+	thisCmd := &HookDeleteCommand{
+		SoftlayerCommand: sl,
+		AccountManager:   managers.NewAccountManager(sl.Session),
+	}
+
+	cobraCmd := &cobra.Command{
+		Use:   "hook-delete " + T("IDENTIFIER"),
+		Short: T("Delete a provisioning scriptt."),
+		Args:  metadata.OneArgs,
+		RunE: func(cmd *cobra.Command, args []string) error {
+			return thisCmd.Run(args)
+		},
+	}
+
+	thisCmd.Command = cobraCmd
+	return thisCmd
+}
+
+func (cmd *HookDeleteCommand) Run(args []string) error {
+
+	hookID, err := strconv.Atoi(args[0])
+	if err != nil {
+		return errors.NewInvalidSoftlayerIdInputError("Hook ID")
+	}
+
+	success, err := cmd.AccountManager.DeleteProvisioningScript(hookID)
+	if err != nil {
+		return errors.NewAPIError(T("Failed to delete Provisioning Hook."), err.Error(), 2)
+	}
+
+	if success {
+		cmd.UI.Ok()
+		cmd.UI.Print(T("Successfully removed Provisioning Hook."))
+	}
+	return nil
+}

plugin/commands/account/hook_delete_test.go

@@ -0,0 +1,74 @@
+package account_test
+
+import (
+	"errors"
+
+	"github.com/IBM-Cloud/ibm-cloud-cli-sdk/testhelpers/terminal"
+	. "github.com/onsi/ginkgo"
+	. "github.com/onsi/gomega"
+
+	"github.com/softlayer/softlayer-go/session"
+
+	"github.ibm.com/SoftLayer/softlayer-cli/plugin/commands/account"
+	"github.ibm.com/SoftLayer/softlayer-cli/plugin/metadata"
+	"github.ibm.com/SoftLayer/softlayer-cli/plugin/testhelpers"
+)
+
+var _ = Describe("account hook-delete", func() {
+	var (
+		fakeUI             *terminal.FakeUI
+		cliCommand         *account.HookDeleteCommand
+		fakeSession        *session.Session
+		slCommand          *metadata.SoftlayerCommand
+		fakeAccountManager *testhelpers.FakeAccountManager
+	)
+	BeforeEach(func() {
+		fakeUI = terminal.NewFakeUI()
+		fakeSession = testhelpers.NewFakeSoftlayerSession([]string{})
+		fakeAccountManager = new(testhelpers.FakeAccountManager)
+		slCommand = metadata.NewSoftlayerCommand(fakeUI, fakeSession)
+		cliCommand = account.NewHookDeleteCommand(slCommand)
+		cliCommand.Command.PersistentFlags().Var(cliCommand.OutputFlag, "output", "--output=JSON for json output.")
+		cliCommand.AccountManager = fakeAccountManager
+	})
+
+	Describe("account hook-delete", func() {
+
+		Context("Return error", func() {
+			It("return error", func() {
+				err := testhelpers.RunCobraCommand(cliCommand.Command)
+				Expect(err).To(HaveOccurred())
+				Expect(err.Error()).To(ContainSubstring("Incorrect Usage: This command requires one argument"))
+			})
+
+			It("return error", func() {
+				err := testhelpers.RunCobraCommand(cliCommand.Command, "abc")
+				Expect(err).To(HaveOccurred())
+				Expect(err.Error()).To(ContainSubstring("Invalid input for 'Hook ID'. It must be a positive integer."))
+			})
+		})
+
+		Context("Return error", func() {
+			BeforeEach(func() {
+				fakeAccountManager.DeleteProvisioningScriptReturns(false, errors.New("Failed to delete Provisioning Hook"))
+			})
+			It("Failed to delete Provisioning Hook", func() {
+				err := testhelpers.RunCobraCommand(cliCommand.Command, "123456")
+				Expect(err).To(HaveOccurred())
+				Expect(err.Error()).To(ContainSubstring("Failed to delete Provisioning Hook"))
+			})
+		})
+
+		Context("Return no error", func() {
+			BeforeEach(func() {
+				fakeAccountManager.DeleteProvisioningScriptReturns(true, nil)
+			})
+			It("Return no error", func() {
+				err := testhelpers.RunCobraCommand(cliCommand.Command, "123456")
+				Expect(err).NotTo(HaveOccurred())
+				Expect(fakeUI.Outputs()).To(ContainSubstring("OK"))
+				Expect(fakeUI.Outputs()).To(ContainSubstring("Successfully removed Provisioning Hook."))
+			})
+		})
+	})
+})

plugin/managers/account.go

@@ -30,6 +30,7 @@ type AccountManager interface {
 	GetBandwidthPoolDetail(bandwidthPoolId int, mask string) (datatypes.Network_Bandwidth_Version1_Allotment, error)
 	GetPostProvisioningHooks(mask string) ([]datatypes.Provisioning_Hook, error)
 	CreateProvisioningScript(template datatypes.Provisioning_Hook) (datatypes.Provisioning_Hook, error)
+	DeleteProvisioningScript(idProvisioningScript int) (resp bool, err error)
 }
 
 type accountManager struct {
@@ -373,3 +374,12 @@ func (a accountManager) CreateProvisioningScript(template datatypes.Provisioning
 	provisioningHook := services.GetProvisioningHookService(a.Session)
 	return provisioningHook.CreateObject(&template)
 }
+
+/*
+Delete a provisioning script.
+https://sldn.softlayer.com/reference/services/SoftLayer_Provisioning_Hook/deleteObject/
+*/
+func (a accountManager) DeleteProvisioningScript(idProvisioningScript int) (resp bool, err error) {
+	provisioningHook := services.GetProvisioningHookService(a.Session)
+	return provisioningHook.Id(idProvisioningScript).DeleteObject()
+}