Merge pull request #667 from Brian-Flores/issue665

New Command: `ibmcloud sl account hook-create`

Author: allmightyspiff

plugin/commands/account/account.go

@@ -28,6 +28,7 @@ func SetupCobraCommands(sl *metadata.SoftlayerCommand) *cobra.Command {
 	cobraCmd.AddCommand(NewOrdersCommand(sl).Command)
 	cobraCmd.AddCommand(NewSummaryCommand(sl).Command)
 	cobraCmd.AddCommand(NewHooksCommand(sl).Command)
+	cobraCmd.AddCommand(NewHookCreateCommand(sl).Command)
 	return cobraCmd
 }
 

plugin/commands/account/account_test.go

@@ -24,6 +24,7 @@ var availableCommands = []string{
 	"cancel-item",
 	"event-detail",
 	"events",
+	"hook-create",
 	"hooks",
 	"invoice-detail",
 	"invoices",

plugin/commands/account/hook_create.go

@@ -0,0 +1,72 @@
+package account
+
+import (
+	"github.com/softlayer/softlayer-go/datatypes"
+	"github.com/softlayer/softlayer-go/sl"
+	"github.com/spf13/cobra"
+
+	"github.ibm.com/SoftLayer/softlayer-cli/plugin/errors"
+	. "github.ibm.com/SoftLayer/softlayer-cli/plugin/i18n"
+	"github.ibm.com/SoftLayer/softlayer-cli/plugin/managers"
+	"github.ibm.com/SoftLayer/softlayer-cli/plugin/metadata"
+	"github.ibm.com/SoftLayer/softlayer-cli/plugin/utils"
+)
+
+type HookCreateCommand struct {
+	*metadata.SoftlayerCommand
+	AccountManager managers.AccountManager
+	Command        *cobra.Command
+	Name           string
+	Uri            string
+}
+
+func NewHookCreateCommand(sl *metadata.SoftlayerCommand) *HookCreateCommand {
+	thisCmd := &HookCreateCommand{
+		SoftlayerCommand: sl,
+		AccountManager:   managers.NewAccountManager(sl.Session),
+	}
+
+	cobraCmd := &cobra.Command{
+		Use:   "hook-create",
+		Short: T("Order/create a provisioning script."),
+		Args:  metadata.NoArgs,
+		RunE: func(cmd *cobra.Command, args []string) error {
+			return thisCmd.Run(args)
+		},
+	}
+
+	cobraCmd.Flags().StringVarP(&thisCmd.Name, "name", "N", "", T("The name of the hook."))
+	cobraCmd.Flags().StringVarP(&thisCmd.Uri, "uri", "U", "", T("The endpoint that the script will be downloaded."))
+
+	//#nosec G104 -- This is a false positive
+	cobraCmd.MarkFlagRequired("name")
+	//#nosec G104 -- This is a false positive
+	cobraCmd.MarkFlagRequired("uri")
+
+	thisCmd.Command = cobraCmd
+	return thisCmd
+}
+
+func (cmd *HookCreateCommand) Run(args []string) error {
+
+	outputFormat := cmd.GetOutputFlag()
+
+	hookTemplate := datatypes.Provisioning_Hook{
+		Name: sl.String(cmd.Name),
+		Uri:  sl.String(cmd.Uri),
+	}
+
+	provisioningHook, err := cmd.AccountManager.CreateProvisioningScript(hookTemplate)
+	if err != nil {
+		return errors.NewAPIError(T("Failed to create Provisioning Hook."), err.Error(), 2)
+	}
+
+	table := cmd.UI.Table([]string{T("Name"), T("Value")})
+	table.Add(T("Id"), utils.FormatIntPointer(provisioningHook.Id))
+	table.Add(T("Name"), utils.FormatStringPointer(provisioningHook.Name))
+	table.Add(T("Created"), utils.FormatSLTimePointer(provisioningHook.CreateDate))
+	table.Add(T("Uri"), utils.FormatStringPointer(provisioningHook.Uri))
+
+	utils.PrintTable(cmd.UI, table, outputFormat)
+	return nil
+}

plugin/commands/account/hook_create_test.go

@@ -0,0 +1,81 @@
+package account_test
+
+import (
+	"errors"
+	"time"
+
+	"github.com/IBM-Cloud/ibm-cloud-cli-sdk/testhelpers/terminal"
+	. "github.com/onsi/ginkgo"
+	. "github.com/onsi/gomega"
+
+	"github.com/softlayer/softlayer-go/datatypes"
+	"github.com/softlayer/softlayer-go/session"
+	"github.com/softlayer/softlayer-go/sl"
+
+	"github.ibm.com/SoftLayer/softlayer-cli/plugin/commands/account"
+	"github.ibm.com/SoftLayer/softlayer-cli/plugin/metadata"
+	"github.ibm.com/SoftLayer/softlayer-cli/plugin/testhelpers"
+)
+
+var _ = Describe("account hook-create", func() {
+	var (
+		fakeUI             *terminal.FakeUI
+		cliCommand         *account.HookCreateCommand
+		fakeSession        *session.Session
+		slCommand          *metadata.SoftlayerCommand
+		fakeAccountManager *testhelpers.FakeAccountManager
+	)
+	BeforeEach(func() {
+		fakeUI = terminal.NewFakeUI()
+		fakeSession = testhelpers.NewFakeSoftlayerSession([]string{})
+		fakeAccountManager = new(testhelpers.FakeAccountManager)
+		slCommand = metadata.NewSoftlayerCommand(fakeUI, fakeSession)
+		cliCommand = account.NewHookCreateCommand(slCommand)
+		cliCommand.Command.PersistentFlags().Var(cliCommand.OutputFlag, "output", "--output=JSON for json output.")
+		cliCommand.AccountManager = fakeAccountManager
+	})
+
+	Describe("account hook-create", func() {
+
+		Context("Return error", func() {
+
+			It("Set invalid output", func() {
+				err := testhelpers.RunCobraCommand(cliCommand.Command, "--name=myhook", "--uri=http://myuritest.com", "--output=xml")
+				Expect(err).To(HaveOccurred())
+				Expect(err.Error()).To(ContainSubstring("Incorrect Usage: Invalid output format, only JSON is supported now."))
+			})
+		})
+
+		Context("Return error", func() {
+			BeforeEach(func() {
+				fakeAccountManager.CreateProvisioningScriptReturns(datatypes.Provisioning_Hook{}, errors.New("Failed to create Provisioning Hook"))
+			})
+			It("Failed to create Provisioning Hook", func() {
+				err := testhelpers.RunCobraCommand(cliCommand.Command, "--name=myhook", "--uri=http://myuritest.com")
+				Expect(err).To(HaveOccurred())
+				Expect(err.Error()).To(ContainSubstring("Failed to create Provisioning Hook"))
+			})
+		})
+
+		Context("Return no error", func() {
+			BeforeEach(func() {
+				created, _ := time.Parse(time.RFC3339, "2017-11-08T00:00:00Z")
+				fakerHook := datatypes.Provisioning_Hook{
+					Id:         sl.Int(123456),
+					Name:       sl.String("My Hook"),
+					CreateDate: sl.Time(created),
+					Uri:        sl.String("http://myuritest.com"),
+				}
+				fakeAccountManager.CreateProvisioningScriptReturns(fakerHook, nil)
+			})
+			It("Return no error", func() {
+				err := testhelpers.RunCobraCommand(cliCommand.Command, "--name=myhook", "--uri=http://myuritest.com")
+				Expect(err).NotTo(HaveOccurred())
+				Expect(fakeUI.Outputs()).To(ContainSubstring("123456"))
+				Expect(fakeUI.Outputs()).To(ContainSubstring("My Hook"))
+				Expect(fakeUI.Outputs()).To(ContainSubstring("2017-11-08T00:00:00Z"))
+				Expect(fakeUI.Outputs()).To(ContainSubstring("http://myuritest.com"))
+			})
+		})
+	})
+})

plugin/managers/account.go

@@ -29,6 +29,7 @@ type AccountManager interface {
 	GetSummary(mask string) (datatypes.Account, error)
 	GetBandwidthPoolDetail(bandwidthPoolId int, mask string) (datatypes.Network_Bandwidth_Version1_Allotment, error)
 	GetPostProvisioningHooks(mask string) ([]datatypes.Provisioning_Hook, error)
+	CreateProvisioningScript(template datatypes.Provisioning_Hook) (datatypes.Provisioning_Hook, error)
 }
 
 type accountManager struct {
@@ -363,3 +364,12 @@ func (a accountManager) GetPostProvisioningHooks(mask string) ([]datatypes.Provi
 	}
 	return a.AccountService.Mask(mask).GetPostProvisioningHooks()
 }
+
+/*
+Create a provisioning script.
+https://sldn.softlayer.com/reference/services/SoftLayer_Provisioning_Hook/createObject/
+*/
+func (a accountManager) CreateProvisioningScript(template datatypes.Provisioning_Hook) (datatypes.Provisioning_Hook, error) {
+	provisioningHook := services.GetProvisioningHookService(a.Session)
+	return provisioningHook.CreateObject(&template)
+}