Skip to content

Commit bdf70bd

Browse files
allmightyspiffGitHub Enterprise
authored andcommitted
Merge pull request #777 from Ramkishor-Chaladi/issue_776
hidden the deprecated permissions from user list output
2 parents 1aa0c49 + 510d8ab commit bdf70bd

2 files changed

Lines changed: 29 additions & 1 deletion

File tree

plugin/commands/user/permissions.go

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,17 @@ func (cmd *PermissionsCommand) Run(args []string) error {
8484
}
8585

8686
}
87-
tablePermission.Add(utils.FormatStringPointer(perm.Name), utils.FormatStringPointer(perm.KeyName), strconv.FormatBool(assigned))
87+
flag := true
88+
arr := []string{"ACCOUNT_SUMMARY_VIEW", "REQUEST_COMPLIANCE_REPORT", "COMPANY_EDIT", "ONE_TIME_PAYMENTS", "UPDATE_PAYMENT_DETAILS",
89+
"EU_LIMITED_PROCESSING_MANAGE", "TICKET_ADD", "TICKET_EDIT", "TICKET_SEARCH", "TICKET_VIEW", "TICKET_VIEW_ALL"}
90+
for i := 0; i < len(arr); i++ {
91+
if *perm.KeyName == arr[i] {
92+
flag = false
93+
}
94+
}
95+
if flag == true {
96+
tablePermission.Add(utils.FormatStringPointer(perm.Name), utils.FormatStringPointer(perm.KeyName), strconv.FormatBool(assigned))
97+
}
8898
}
8999
tablePermission.Print()
90100
return nil

plugin/commands/user/permissions_test.go

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,24 @@ var _ = Describe("User Permissions", func() {
107107
})
108108
})
109109

110+
Context("hide user permissions", func() {
111+
It("return not equal user permissions", func() {
112+
err := testhelpers.RunCobraCommand(cliCommand.Command, "123")
113+
Expect(err).NotTo(HaveOccurred())
114+
Expect(fakeUI.Outputs()).NotTo(Equal("ACCOUNT_SUMMARY_VIEW"))
115+
Expect(fakeUI.Outputs()).To(Not(Equal("REQUEST_COMPLIANCE_REPORT")))
116+
Expect(fakeUI.Outputs()).To(Not(Equal("COMPANY_EDIT")))
117+
Expect(fakeUI.Outputs()).To(Not(Equal("ONE_TIME_PAYMENTS")))
118+
Expect(fakeUI.Outputs()).To(Not(Equal("UPDATE_PAYMENT_DETAILS")))
119+
Expect(fakeUI.Outputs()).To(Not(Equal("EU_LIMITED_PROCESSING_MANAGE")))
120+
Expect(fakeUI.Outputs()).To(Not(Equal("TICKET_ADD")))
121+
Expect(fakeUI.Outputs()).To(Not(Equal("TICKET_EDIT")))
122+
Expect(fakeUI.Outputs()).To(Not(Equal("TICKET_SEARCH")))
123+
Expect(fakeUI.Outputs()).To(Not(Equal("TICKET_VIEW")))
124+
Expect(fakeUI.Outputs()).To(Not(Equal("TICKET_VIEW_ALL")))
125+
})
126+
})
127+
110128
Context("user permissions - master account", func() {
111129
It("return user permissions", func() {
112130
fakeUserManager.GetUserReturns(datatypes.User_Customer{

0 commit comments

Comments
 (0)