Skip to content

Commit 6877108

Browse files
caberoscaberos
authored andcommitted
fix the team code review comments
1 parent 57d349d commit 6877108

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

SoftLayer/CLI/hardware/add_notification.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
@click.command(cls=SoftLayer.CLI.command.SLCommand, )
1212
@click.argument('identifier')
1313
@click.option('--users', multiple=True,
14-
help='An IP address to authorize ')
14+
help='UserId to be notified on monitoring failure.')
1515
@environment.pass_env
1616
def cli(env, identifier, users):
1717
"""Create a user hardware notification entry."""
@@ -26,6 +26,6 @@ def cli(env, identifier, users):
2626
notification = hardware.add_notification(identifier, user)
2727
table.add_row([notification['id'], notification['hardware']['fullyQualifiedDomainName'],
2828
notification['user']['username'], notification['user']['email'],
29-
notification['user']['lastName'], notification['user']['firstName']])
29+
notification['user']['firstName'], notification['user']['lastName']])
3030

3131
env.fout(table)

SoftLayer/CLI/hardware/notifications.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,6 @@ def cli(env, identifier):
2525
for notification in notifications:
2626
table.add_row([notification['hardware']['fullyQualifiedDomainName'], notification['hardware']['hostname'],
2727
notification['user']['username'], notification['user']['email'],
28-
notification['user']['lastName'], notification['user']['firstName']])
28+
notification['user']['firstName'], notification['user']['lastName']])
2929

3030
env.fout(table)

0 commit comments

Comments
 (0)